Fix router's TLS validation config

[nota-ja]

Gorouter uses skip_ssl_validation, not ssl_skip_validation.

• https://github.com/cloudfoundry/gorouter/blob/5171527e7054dd3b69b74eac97426eb324974a71/config/config.go#L52
• https://github.com/cloudfoundry/gorouter/blob/5171527e7054dd3b69b74eac97426eb324974a71/config/config.go#L97

As far as I know, this bug makes a CF app not working as a route service on the pcfdev environment.

[aemengo]

Thanks for the pointer. However, the version of cf-release bundled with PCF Dev is currently v235 and this version has a gorouter property called ssl_skip_validation, viewable here: https://github.com/cloudfoundry/cf-release/blob/v235/jobs/gorouter/spec#L62-L64

The latest version of cf-release v239 currently has the same property set as well: https://github.com/cloudfoundry-incubator/routing-release/blob/6da24d260eb1a8482845c3a77ee5ab4320e35eb8/jobs/gorouter/spec#L64-L66

We'll be sure to watch this property to see if this rename occurs.

But for now (v239), it looks like this property gets renamed when the router configuration template is rendered before deployment: https://github.com/cloudfoundry-incubator/routing-release/blob/6da24d260eb1a8482845c3a77ee5ab4320e35eb8/jobs/gorouter/templates/gorouter.yml.erb#L47
https://github.com/cloudfoundry-incubator/routing-release/blob/6da24d260eb1a8482845c3a77ee5ab4320e35eb8/jobs/gorouter/templates/gorouter.yml.erb#L65

[nota-ja]

Oh, I see.
So there should be another reason why my pcfdev's gorouter is misconfigured. Or I might be trapped in a versioning gap.
Anyway, thank you for taking time to explain, @aemengo.

[aemengo]

No problem! Please feel free to submit a github issue with the symptoms that you're seeing and the steps to reproduce, so that we can help you out.