Change lifecycle tests per open-telemetry#2757

Author: pjanotti

service/defaultcomponents/default_exporters_test.go

@@ -176,13 +176,13 @@ func verifyExporterLifecycle(t *testing.T, factory component.ExporterFactory, ge
 		}
 		require.NoError(t, err)
 		require.NoError(t, firstExp.Start(ctx, host))
+		require.NoError(t, firstExp.Shutdown(ctx))
 
 		secondExp, err := createFn(ctx, expCreateParams, getConfigFn())
-		assert.NoError(t, err)
+		require.NoError(t, err)
 
-		assert.NoError(t, firstExp.Shutdown(ctx))
-		assert.NoError(t, secondExp.Start(ctx, host))
-		assert.NoError(t, secondExp.Shutdown(ctx))
+		require.NoError(t, secondExp.Start(ctx, host))
+		require.NoError(t, secondExp.Shutdown(ctx))
 	}
 }
 

service/defaultcomponents/default_extensions_test.go

@@ -12,8 +12,6 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
-// Program otelcol is the OpenTelemetry Collector that collects stats
-// and traces and exports to a configured backend.
 package defaultcomponents
 
 import (
@@ -89,13 +87,13 @@ func verifyExtensionLifecycle(t *testing.T, factory component.ExtensionFactory,
 	firstExt, err := factory.CreateExtension(ctx, extCreateParams, getConfigFn())
 	require.NoError(t, err)
 	require.NoError(t, firstExt.Start(ctx, host))
+	require.NoError(t, firstExt.Shutdown(ctx))
 
 	secondExt, err := factory.CreateExtension(ctx, extCreateParams, getConfigFn())
-	assert.NoError(t, err)
+	require.NoError(t, err)
 
-	assert.NoError(t, firstExt.Shutdown(ctx))
-	assert.NoError(t, secondExt.Start(ctx, host))
-	assert.NoError(t, secondExt.Shutdown(ctx))
+	require.NoError(t, secondExt.Start(ctx, host))
+	require.NoError(t, secondExt.Shutdown(ctx))
 }
 
 // assertNoErrorHost implements a component.Host that asserts that there were no errors.

service/defaultcomponents/default_processors_test.go

@@ -138,13 +138,13 @@ func verifyProcessorLifecycle(t *testing.T, factory component.ProcessorFactory,
 		}
 		require.NoError(t, err)
 		require.NoError(t, firstExp.Start(ctx, host))
+		require.NoError(t, firstExp.Shutdown(ctx))
 
 		secondExp, err := createFn(ctx, processorCreateParams, getConfigFn())
-		assert.NoError(t, err)
+		require.NoError(t, err)
 
-		assert.NoError(t, firstExp.Shutdown(ctx))
-		assert.NoError(t, secondExp.Start(ctx, host))
-		assert.NoError(t, secondExp.Shutdown(ctx))
+		require.NoError(t, secondExp.Start(ctx, host))
+		require.NoError(t, secondExp.Shutdown(ctx))
 	}
 }
 

service/defaultcomponents/default_receivers_test.go

@@ -130,13 +130,13 @@ func verifyReceiverLifecycle(t *testing.T, factory component.ReceiverFactory, ge
 		}
 		require.NoError(t, err)
 		require.NoError(t, firstRcvr.Start(ctx, host))
+		require.NoError(t, firstRcvr.Shutdown(ctx))
 
 		secondRcvr, err := createFn(ctx, receiverCreateParams, getConfigFn())
-		assert.NoError(t, err)
+		require.NoError(t, err)
 
-		assert.NoError(t, firstRcvr.Shutdown(ctx))
-		assert.NoError(t, secondRcvr.Start(ctx, host))
-		assert.NoError(t, secondRcvr.Shutdown(ctx))
+		require.NoError(t, secondRcvr.Start(ctx, host))
+		require.NoError(t, secondRcvr.Shutdown(ctx))
 	}
 }