Discord Events#147
Conversation
SaadBazaz
left a comment
SaadBazaz
left a comment
There was a problem hiding this comment.
Sorry for the review post-merge, but best to catch some small nits here.
| Assets/chromedriver* | ||
| Assets/msedgedriver.exe | ||
| Assets/msedgedriver.exe.meta | ||
| Assets/PlayroomKit/src/frameworks copy.ts |
There was a problem hiding this comment.
I think this is a typo or a dev artifact. Why does this file exist in the first place?
There was a problem hiding this comment.
Was testing types, so made that, I want to move the bridge (index JS) to Typescript for code completion and use that to generate JSLIB (adding a copy command, instead of npm i), I will create an issue for that.
|
|
||
| public void SubscribeDiscordEvent(SDKEvent eventName, Action<string> callback) | ||
| { | ||
| DebugLogger.LogWarning("[MockMode] Discord events only work inside discord!"); |
There was a problem hiding this comment.
Can we have local browser mock-mode work with Discord? e.g. by putting localhost:3000 in the Discord Developer portal? If yes, this should probably read "Discord events not supported in browser mock mode!" like the others.
There was a problem hiding this comment.
The game needs to run inside discord to call any commands from discord sdk or subscribe to those events, I don't its gonna work.
|
|
||
| public void SubscribeDiscordEvent(SDKEvent eventName, Action<string> callback) | ||
| { | ||
| DebugLogger.LogWarning("[MockMode] Discord events only work inside discord!"); |
There was a problem hiding this comment.
This is local / single player mode
2 participants
Support for the following Events: