fix(ci): use napi create-npm-dir for @napi-rs/cli v2 in SDK release#60
Conversation
|
Note Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe SDK release workflow now uses ChangesSDK release workflow
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Up to standards ✅🟢 Issues
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
|



Summary
Fix the SDK release workflow (
release-sdk.yml) which was callingbunx napi create-npm-dirs(plural) — a subcommand that only exists in@napi-rs/cliv3. The repo pins@napi-rs/cli@^2.18.4(seecrates/csp-node/package.json), and v2 does not recognizecreate-npm-dirs, causing the workflow to fail with "Command not found".Changes
bunx napi create-npm-dirs→bunx napi create-npm-dir(singular, the correct v2 subcommand)Root Cause
create-npm-dirs(plural) is the v3 CLI name;create-npm-dir(singular) is the v2 name. Since the project pins v2, the singular form is required.Test Plan
Assemble platform packagesstep passesSummary by cubic
Fix SDK release workflow by using the correct
napisubcommand for@napi-rs/cliv2. This removes the "Command not found" error and unblocks the "Assemble platform packages" step.bunx napi create-npm-dirswithbunx napi create-npm-dirand update the inline comment.Written for commit c1224e8. Summary will update on new commits.
Summary by CodeRabbit