From 33eca445baec3d6b54c4370a95fa6c25d2471b54 Mon Sep 17 00:00:00 2001 From: Minsu Lee Date: Thu, 18 Jun 2026 16:13:53 +0900 Subject: [PATCH] docs: remove stale stub/TODO comments on implemented modules (#29) Several modules carried 'Minimal stub' / TODO(integration) / 'throwing stub' comments that were stale: the code is fully implemented. These misled readers. - src/types.ts: drop 'Minimal stub' note (Chunk/SearchResult + dict round-trip helpers are all implemented) - src/utils.ts: drop 'Minimal stub' note (isGitUrl/resolveChunk/formatResults implemented) - src/cli.ts: drop TODO(integration) -- all sibling imports are real and wired - src/indexing/index.ts: rewrite the 'Wiring status' block; fromGit and loadFromDisk are fully implemented, so the stub/throwing-stub language and obsolete T00x task references are removed in favor of an accurate summary Comments only -- no behavior change. --- src/cli.ts | 1 - src/indexing/index.ts | 15 ++++++++------- src/types.ts | 1 - src/utils.ts | 1 - 4 files changed, 8 insertions(+), 10 deletions(-) diff --git a/src/cli.ts b/src/cli.ts index 79ad6bc..97105a3 100644 --- a/src/cli.ts +++ b/src/cli.ts @@ -5,7 +5,6 @@ import { dirname, resolve } from 'node:path' import process from 'node:process' import { fileURLToPath } from 'node:url' -// TODO(integration): replace stub when sibling modules land import { clearIndexCache, loadOrBuildIndex } from './indexing/cache.ts' import { CspIndex } from './indexing/index.ts' import { serve } from './mcp/server.ts' diff --git a/src/indexing/index.ts b/src/indexing/index.ts index f051b80..6dc601a 100644 --- a/src/indexing/index.ts +++ b/src/indexing/index.ts @@ -4,13 +4,14 @@ // indexing units (model loading + createIndexFromPath) into a single object // that the CLI and MCP server drive. // -// Wiring status: -// - fromPath: implemented (this task, T003). -// - fromGit: stub (T005). -// - search / findRelated: sync delegation to search.ts (T004). -// - save: implemented (this task, T006) — writes manifest + chunks + bm25 + dense. -// - loadFromDisk: throwing stub (real persistence in T007); declared here so -// the Phase A/B branch type-checks (cli.ts references CspIndex.loadFromDisk). +// Construction: +// - fromPath: index a local directory. +// - fromGit: shallow-clone a git URL into a temp dir, index it via +// fromPath, then re-root the index at the URL. +// - loadFromDisk: reconstruct a saved index from its on-disk artifacts. +// Operations: +// - search / findRelated: delegate to search.ts over the in-memory index. +// - save: persist the index (manifest + chunks + bm25 + dense vectors). import type { Chunk, ContentType, IndexStats, SearchResult } from '../types.ts' import type { Model } from './dense.ts' diff --git a/src/types.ts b/src/types.ts index 71b60ee..9138704 100644 --- a/src/types.ts +++ b/src/types.ts @@ -1,5 +1,4 @@ // Port of src/semble/types.py -// Minimal stub — full implementation lands in Unit 1. /** Call type for token-savings tracking. */ export enum CallType { diff --git a/src/utils.ts b/src/utils.ts index 28f17c7..cbc22d9 100644 --- a/src/utils.ts +++ b/src/utils.ts @@ -1,5 +1,4 @@ // Port of src/semble/utils.py -// Minimal stub — full implementation lands in Unit 3. import type { Chunk, SearchResult } from './types.ts'