From f865fcd5a6e28316f06c65fee018c1b31de7ad44 Mon Sep 17 00:00:00 2001 From: wbrgss Date: Thu, 12 Dec 2019 18:53:49 -0500 Subject: [PATCH 1/5] height: 100% on td see https://stackoverflow.com/questions/3215553/make-a-div-fill-an-entire-table-cell#comment40719119_7600749 --- src/dash-table/components/Table/Table.less | 1 + 1 file changed, 1 insertion(+) diff --git a/src/dash-table/components/Table/Table.less b/src/dash-table/components/Table/Table.less index fe3422494..f5cf45eb2 100644 --- a/src/dash-table/components/Table/Table.less +++ b/src/dash-table/components/Table/Table.less @@ -494,6 +494,7 @@ * tried it. */ overflow-x: visible; + height: 100%; } .dash-spreadsheet-inner :not(.cell--selected) tr:hover, From 7868ab7fa4488aee72012c15ace055aff63d4006 Mon Sep 17 00:00:00 2001 From: wbrgss Date: Fri, 13 Dec 2019 13:15:05 -0500 Subject: [PATCH 2/5] Try height only on non-string "dropdown" cells --- src/dash-table/components/Table/Table.less | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/dash-table/components/Table/Table.less b/src/dash-table/components/Table/Table.less index f5cf45eb2..8aa2d331f 100644 --- a/src/dash-table/components/Table/Table.less +++ b/src/dash-table/components/Table/Table.less @@ -494,7 +494,10 @@ * tried it. */ overflow-x: visible; - height: 100%; + } + + .dash-spreadsheet-inner td.dropdown:not([data-dash-column="string"]) { + height: 100%; } .dash-spreadsheet-inner :not(.cell--selected) tr:hover, From c0b2d41c22aad7b3de28b4c876a4a6262d813785 Mon Sep 17 00:00:00 2001 From: wbrgss Date: Fri, 13 Dec 2019 17:04:37 -0500 Subject: [PATCH 3/5] Adjust dropdown div instead of td and scope to FF --- src/dash-table/components/Table/Table.less | 16 ++++++++++++---- 1 file changed, 12 insertions(+), 4 deletions(-) diff --git a/src/dash-table/components/Table/Table.less b/src/dash-table/components/Table/Table.less index 8aa2d331f..b9e745874 100644 --- a/src/dash-table/components/Table/Table.less +++ b/src/dash-table/components/Table/Table.less @@ -399,6 +399,18 @@ } } + /* + * fixes Firefox td height bug on td > dropdown children + * bug should only appear on FF but + * @supports = scoped to Firefox only + * to minimize side effects + */ + @supports (-moz-appearance:none) { + td.dropdown .dash-cell-value-container { + height: auto; + } + } + th.dash-filter { position: relative; @@ -496,10 +508,6 @@ overflow-x: visible; } - .dash-spreadsheet-inner td.dropdown:not([data-dash-column="string"]) { - height: 100%; - } - .dash-spreadsheet-inner :not(.cell--selected) tr:hover, tr:hover input :not(.cell--selected) { background-color: var(--hover); From 0ce326f02afee250ec1d06de964f5d5f5fb4070d Mon Sep 17 00:00:00 2001 From: wbrgss Date: Fri, 13 Dec 2019 17:06:41 -0500 Subject: [PATCH 4/5] spacing --- src/dash-table/components/Table/Table.less | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/dash-table/components/Table/Table.less b/src/dash-table/components/Table/Table.less index b9e745874..0017cb701 100644 --- a/src/dash-table/components/Table/Table.less +++ b/src/dash-table/components/Table/Table.less @@ -406,10 +406,10 @@ * to minimize side effects */ @supports (-moz-appearance:none) { - td.dropdown .dash-cell-value-container { - height: auto; - } - } + td.dropdown .dash-cell-value-container { + height: auto; + } + } th.dash-filter { position: relative; From 65c73ac220c8e6eb74c93d2541ff3e91d261019e Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Marc-Andre=CC=81=20Rivet?= Date: Tue, 14 Jan 2020 09:15:17 -0500 Subject: [PATCH 5/5] changelog --- CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 81f26ef29..cf819bcbf 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -10,6 +10,7 @@ This project adheres to [Semantic Versioning](http://semver.org/). ### Fixed - [#670](https://github.com/plotly/dash-table/pull/670) Fix a bug where `derived_filter_query_structure` was not getting updated properly +- [#665](https://github.com/plotly/dash-table/pull/665) Fix a bug in Firefox where the dropdown cells height is incorrect ## [4.5.1] - 2019-11-14 ### Fixed