From eaa954a84cd81b13ff0ef42742f5a1878fb91c8e Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Nicolas=20Rothenh=C3=A4usler?= Date: Mon, 23 Mar 2020 15:18:34 +0100 Subject: [PATCH 1/2] Clarify optional nature of row_id in active_cell --- src/dash-table/dash/DataTable.js | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/dash-table/dash/DataTable.js b/src/dash-table/dash/DataTable.js index 6c53e4685..f347cb98d 100644 --- a/src/dash-table/dash/DataTable.js +++ b/src/dash-table/dash/DataTable.js @@ -110,7 +110,8 @@ export const defaultProps = { export const propTypes = { /** - * The row and column indices and IDs of the currently active cell. + * The row and column indices and IDs of the currently active cell. + * `row_id` is only returned if the data rows have an `id` key. */ active_cell: PropTypes.exact({ row: PropTypes.number, @@ -1299,4 +1300,4 @@ DataTable.persistenceTransforms = { }; DataTable.defaultProps = defaultProps; -DataTable.propTypes = propTypes; \ No newline at end of file +DataTable.propTypes = propTypes; From fcee1a1649588d47d2d190be25e9c0cb19d2c1a7 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Marc-Andr=C3=A9=20Rivet?= Date: Wed, 15 Apr 2020 18:36:24 -0400 Subject: [PATCH 2/2] Update CHANGELOG.md --- CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 181b4ccc4..088014c3e 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -6,6 +6,7 @@ This project adheres to [Semantic Versioning](http://semver.org/). ### Fixed - [#722](https://github.com/plotly/dash-table/pull/722) Fix a bug where row height is misaligned when using fixed_columns and/or fixed_rows - [#728](https://github.com/plotly/dash-table/pull/728) Fix copy/paste on readonly cells +- [#724](https://github.com/plotly/dash-table/pull/724) Fix `active_cell` docstring: clarify optional nature of the `row_id` nested prop ## [4.6.2] - 2020-04-01 ### Changed