From ba7c467a61cf2a1393660b95cbb5312341a3e0cb Mon Sep 17 00:00:00 2001 From: Chris Parmer Date: Mon, 20 Apr 2020 15:03:19 -0700 Subject: [PATCH 1/2] Improve error message for invalid filter queries --- src/core/syntax-tree/index.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/core/syntax-tree/index.ts b/src/core/syntax-tree/index.ts index c689ddc8a..7838f9d7d 100644 --- a/src/core/syntax-tree/index.ts +++ b/src/core/syntax-tree/index.ts @@ -62,7 +62,7 @@ export default class SyntaxTree { evaluate = (target: any) => { if (!this.isValid) { - const msg = `unable to evaluate target: syntax tree is invalid for query=${this.query}`; + const msg = `DataTable filtering syntax is invalid for query: ${this.query}`; Logger.error(msg); throw new Error(msg); @@ -90,4 +90,4 @@ export default class SyntaxTree { return toStructure(this.syntaxerResult.tree); } -} \ No newline at end of file +} From 191f0ad53a4851b2d59c06e282511bc9307c733d Mon Sep 17 00:00:00 2001 From: Chris Parmer Date: Tue, 21 Apr 2020 07:50:57 -0700 Subject: [PATCH 2/2] Update CHANGELOG.md --- CHANGELOG.md | 3 +++ 1 file changed, 3 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 3064384ec..0fb424ef1 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -18,6 +18,9 @@ This project adheres to [Semantic Versioning](http://semver.org/). - [#732](https://github.com/plotly/dash-table/pull/732) Fix a bug where opening a dropdown scrolled the table down its last row - [#731](https://github.com/plotly/dash-table/pull/731) Fix a bug where `data=None` and `columns=None` caused the table to throw an error +## Changed +- [#758](https://github.com/plotly/dash-table/pull/758) Improve error message for invalid filter queries + ## [4.6.2] - 2020-04-01 ### Changed - [#713](https://github.com/plotly/dash-table/pull/713) Update from React 16.8.6 to 16.13.0