Skip to content

Commit 16b8444

Browse files
committed
chore: fix typecheck error
1 parent 646d90d commit 16b8444

4 files changed

Lines changed: 10 additions & 10 deletions

File tree

packages/polywrap-uri-resolvers/polywrap_uri_resolvers/builder.py

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -5,16 +5,16 @@
55
from .package_resolver import PackageResolver
66
from .wrapper_resolver import WrapperResolver
77

8-
from polywrap_core import IUriResolver
8+
from polywrap_core import IUriResolver, UriPackage, UriWrapper
99

1010

1111
# TODO: Recheck if this should return result or not
1212
def build_resolver(uri_resolver_like: UriResolverLike, name: Optional[str]) -> IUriResolver:
1313
if type(uri_resolver_like) == list:
1414
return UriResolverAggregator(map(lambda r: build_resolver(r, name), uri_resolver_like)) # type: ignore
15-
elif hasattr(uri_resolver_like, "uri") and hasattr(uri_resolver_like, "package"):
16-
return PackageResolver(uri=uri_resolver_like.uri, wrap_package=uri_resolver_like.package) # type: ignore
17-
elif hasattr(uri_resolver_like, "uri") and hasattr(uri_resolver_like, "wrapper"):
18-
return WrapperResolver(uri=uri_resolver_like.uri, wrapper=uri_resolver_like.wrapper) # type: ignore
15+
elif isinstance(uri_resolver_like, UriPackage):
16+
return PackageResolver(uri=uri_resolver_like.uri, wrap_package=uri_resolver_like.package)
17+
elif isinstance(uri_resolver_like, UriWrapper):
18+
return WrapperResolver(uri=uri_resolver_like.uri, wrapper=uri_resolver_like.wrapper)
1919
else:
2020
raise "Unknown resolver-like type" # type: ignore
Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
from typing import List, Union
22

3-
from polywrap_core import IUriResolver, UriPackage, UriWrapper
3+
from polywrap_core import Uri, UriPackage, UriWrapper
44

5-
UriResolverLike = Union[IUriResolver, UriPackage, UriWrapper, List["UriResolverLike"]]
5+
UriResolverLike = Union[Uri, UriPackage, UriWrapper, List["UriResolverLike"]]

packages/polywrap-uri-resolvers/polywrap_uri_resolvers/recursive_resolver.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ class RecursiveResolve(IUriResolver):
1010
resolver: IUriResolver
1111

1212
def __init__(self, resolver: UriResolverLike):
13-
resolver = build_resolver(resolver, None)
13+
resolver = build_resolver(resolver, None) # type: ignore
1414

1515
async def try_resolve_uri(self, uri: Uri, client: Client, resolution_context: IUriResolutionContext) -> Result[UriPackageOrWrapper]:
1616
if resolution_context.is_resolving(uri):

packages/polywrap-uri-resolvers/polywrap_uri_resolvers/static_resolver.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
from typing import List, cast
2-
from polywrap_core import IUriResolutionStep, Wrapper, IWrapPackage, UriResolutionResult, IUriResolver, UriPackageOrWrapper, Uri, Client, IUriResolutionContext, UriPackage, UriWrapper
2+
from polywrap_core import IUriResolutionStep, UriResolutionResult, IUriResolver, UriPackageOrWrapper, Uri, Client, IUriResolutionContext, UriPackage, UriWrapper
33
from polywrap_result import Result, Err, Ok
44

55
from .helpers import UriResolverLike
@@ -46,7 +46,7 @@ async def try_resolve_uri(self, uri: Uri, client: Client, resolution_context: IU
4646
elif isinstance(uri_package_or_wrapper, UriWrapper):
4747
result = UriResolutionResult.ok(uri, None, uri_package_or_wrapper.wrapper)
4848
description = f"Static - Wrapper ({uri.uri})"
49-
elif isinstance(uri_package_or_wrapper, Uri):
49+
elif isinstance(uri_package_or_wrapper, Uri): #type: ignore
5050
result = UriResolutionResult.ok(uri)
5151
description = f"Static - Wrapper ({uri.uri})"
5252

0 commit comments

Comments
 (0)