Feat: Static Resolver implementation#41
Merged
Merged
Conversation
cbrzn
force-pushed
the
feat/uri-resolution-impl
branch
from
35d6561 to
3ae3816
Compare
cbrzn
force-pushed
the
feat/uri-resolution-impl
branch
from
54da472 to
0924020
Compare
Niraj-Kamdar
reviewed
Nov 5, 2022
Niraj-Kamdar
reviewed
Nov 5, 2022
Niraj-Kamdar
reviewed
Nov 5, 2022
Niraj-Kamdar
reviewed
Nov 5, 2022
| def __init__(self, resolvers: List[IUriResolver]): | ||
| self.resolvers = resolvers | ||
|
|
||
| def get_step_description(self) -> str: |
Contributor
There was a problem hiding this comment.
Shouldn't this be get_step_name?
Contributor
Author
There was a problem hiding this comment.
we are following the UriResolverAggregatorBase interface and I think it makes sense to keep it with description
Niraj-Kamdar
reviewed
Nov 5, 2022
| self.uri_map = uri_map | ||
|
|
||
| @staticmethod | ||
| def _from(static_resolver_likes: List[UriResolverLike]) -> "StaticResolver": |
Contributor
There was a problem hiding this comment.
This should be class method instead. Let's name this something else. (Ex: construct_from or from_list, from_array?)
Contributor
Author
There was a problem hiding this comment.
I think it make sense to keep it as a static method, but the name indeed need to be changed; will rename it to from_list
Niraj-Kamdar
reviewed
Nov 5, 2022
Niraj-Kamdar
reviewed
Nov 5, 2022
Niraj-Kamdar
reviewed
Nov 5, 2022
Niraj-Kamdar
reviewed
Nov 5, 2022
Niraj-Kamdar
reviewed
Nov 5, 2022
Niraj-Kamdar
suggested changes
Nov 5, 2022
Contributor
Niraj-Kamdar
left a comment
Niraj-Kamdar
left a comment
There was a problem hiding this comment.
Left some comments regarding better code practices
cbrzn
force-pushed
the
feat/uri-resolution-impl
branch
from
98fb25d to
16b8444
Compare
cbrzn
changed the title
cbrzn
force-pushed
the
feat/uri-resolution-impl
branch
from
16b8444 to
88eb118
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.