Breaking Change: Remove Polywrap Meta Manifest#1432
Merged
Conversation
dOrgJelli
requested review from
Niraj-Kamdar,
cbrzn,
krisbitney,
namesty,
nerfZael and
pileks
as code owners
pileks
previously approved these changes
Nov 22, 2022
| export function migrate(migrate: OldManifest, logger?: ILogger): NewManifest { | ||
| if (migrate.extensions?.meta) { | ||
| logger?.warn( | ||
| `The Polywarp Meta Manifests has been deprecated for plugin projects.` |
Contributor
There was a problem hiding this comment.
See the Grammar comment 👇
| export function migrate(migrate: OldManifest, logger?: ILogger): NewManifest { | ||
| if (migrate.extensions?.meta) { | ||
| logger?.warn( | ||
| `The Polywarp Meta Manifests has been deprecated for app projects.` |
Contributor
There was a problem hiding this comment.
The Polywarp Meta Manifest has been deprecated for plugin projects.
Grammar 😁
| export function migrate(migrate: OldManifest, logger?: ILogger): NewManifest { | ||
| if (migrate.extensions?.meta) { | ||
| logger?.warn( | ||
| `The Polywarp Meta Manifests has been deprecated, please use the new "resources" field in the Polywrap Manifest.` |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since we do not use the contents of the meta manifest currently in any applications, and we've just added support for arbitrary wrapper resources (see #1430), I think it's best to "trip the fat" and remove this feature that is not being used actively.
Currently wrappers.io uses the
namefield in thewrap.infomanifest, as well as it looks for aREADME.mdfile in the artifacts, which is then displays on the website.TODO:
resources: ./resourcesto each wasm wrapper template project, and add a./resources/README.mdfile within it.