CLI - Add --wrapper-envs option to build, codegen, docgen and test#1437
Merged
Conversation
dOrgJelli
previously approved these changes
Dec 3, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remaining work
Comments from 28.11.2022. dev sync
deploycommand parses and imports env variables.Description
This PR aims to give developers a quick and easy way to specify wrapper envs when running CLI commands that support the
-c, --client-configoption.For example, in order to use a non-throttled Infura API key inside the Ethereum Plugin, you can create an
envs.jsonfile like such:{ "ens/ethereum.polywrap.eth": { "connection": { "node": "https://mainnet.infura.io/v3/your_api_key", "networkNameOrChainId": "mainnet" } } }and run a command specifying that file:
Additional notes
A change was made to the Ethereum Plugin in order for it to properly consume the supplied
env, with some comments added as to the reasoning behind the change. The change does the trick, but I feel like we should do a more detailed review as to why we are using the approach we are currently, and maybe set up a more robust solution.