Skip to content

fix: handle map in workflows#1438

Merged
dOrgJelli merged 4 commits into
origin-devfrom
fix/map-return-in-workflows
Dec 3, 2022
Merged

fix: handle map in workflows#1438
dOrgJelli merged 4 commits into
origin-devfrom
fix/map-return-in-workflows

Conversation

@cbrzn
Copy link
Copy Markdown
Contributor

@cbrzn cbrzn commented Dec 1, 2022 •
edited
Loading

closes: #1429

github-advanced-security[bot]
github-advanced-security AI found potential problems Dec 1, 2022
View reviewed changes
Comment thread packages/cli/src/lib/helpers/workflow-validator.ts Fixed
github-advanced-security[bot]
github-advanced-security AI found potential problems Dec 1, 2022
View reviewed changes
Comment thread packages/cli/src/lib/helpers/workflow-validator.ts Fixed
github-advanced-security[bot]
github-advanced-security AI found potential problems Dec 1, 2022
View reviewed changes
Comment thread packages/cli/src/lib/helpers/workflow-validator.ts
`cue vet -d ${selector} ${validateScriptPath} ${jsonOutput}`,
logger
);
const args = [selector, validateScriptPath, jsonOutput];

Check warning

Code scanning / CodeQL

Unsafe shell command constructed from library input

This array element which depends on [library input](1) is later used in a [shell command](2).
Comment thread packages/cli/src/lib/helpers/workflow-validator.ts
`cue vet -d ${selector} ${validateScriptPath} ${jsonOutput}`,
logger
);
const args = [selector, validateScriptPath, jsonOutput];

Check warning

Code scanning / CodeQL

Unsafe shell command constructed from library input

This array element which depends on [library input](1) is later used in a [shell command](2).
Comment thread packages/cli/src/lib/helpers/workflow-validator.ts
`cue vet -d ${selector} ${validateScriptPath} ${jsonOutput}`,
logger
);
const args = [selector, validateScriptPath, jsonOutput];

Check warning

Code scanning / CodeQL

Unsafe shell command constructed from library input

This array element which depends on [library input](1) is later used in a [shell command](2).
Comment thread packages/cli/src/lib/helpers/workflow-validator.ts
logger
);
const args = [selector, validateScriptPath, jsonOutput];
const { stderr } = runCommandSync(`cue vet -d ${args.join(" ")}`, logger);

Check warning

Code scanning / CodeQL

Unsafe shell command constructed from library input

This string concatenation which depends on [library input](1) is later used in a [shell command](2). This string concatenation which depends on [library input](3) is later used in a [shell command](2).
@lgtm-com
Copy link
Copy Markdown

lgtm-com Bot commented Dec 1, 2022

This pull request introduces 3 alerts and fixes 2 when merging 65122c6 into 7ff0c19 - view on LGTM.com

new alerts:

  • 3 for Unsafe shell command constructed from library input

fixed alerts:

  • 2 for Unsafe shell command constructed from library input

Heads-up: LGTM.com's PR analysis will be disabled on the 5th of December, and LGTM.com will be shut down ⏻ completely on the 16th of December 2022. Please enable GitHub code scanning, which uses the same CodeQL engine ⚙️ that powers LGTM.com. For more information, please check out our post on the GitHub blog.

@dOrgJelli dOrgJelli merged commit a91e100 into origin-dev Dec 3, 2022
@dOrgJelli dOrgJelli deleted the fix/map-return-in-workflows branch April 10, 2023 17:01
@dOrgJelli dOrgJelli mentioned this pull request Apr 14, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dOrgJelli dOrgJelli dOrgJelli approved these changes

@krisbitney krisbitney Awaiting requested review from krisbitney

@namesty namesty Awaiting requested review from namesty namesty is a code owner

@nerfZael nerfZael Awaiting requested review from nerfZael

@Niraj-Kamdar Niraj-Kamdar Awaiting requested review from Niraj-Kamdar

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Map should be converted to object when used in workflow

3 participants

@cbrzn @dOrgJelli @github-advanced-security