break: remove client.query() & client.subscribe()#1461
Merged
Conversation
dOrgJelli
requested review from
krisbitney,
namesty and
nerfZael
as code owners
Niraj-Kamdar
previously approved these changes
Dec 21, 2022
Contributor
Niraj-Kamdar
left a comment
Niraj-Kamdar
left a comment
There was a problem hiding this comment.
LGTM! What about subscription?
nerfZael
previously approved these changes
Dec 21, 2022
| "prettier": "2.2.1", | ||
| "rimraf": "3.0.2" | ||
| }, | ||
| "resolutions": { |
Contributor
Author
There was a problem hiding this comment.
This was removed here: #1452
And it turns out it's needed within the top-level package.json because of a problem w/ package resolution within the monorepo. React is still used within the template project, and when you install the react template's deps directly (cd packages/templates/app/typescript-react && yarn) it works, but at the root monorepo level it fails due to mismatched dependencies.
Contributor
I would agree to remove subscription here too! |
Contributor
Same, I don't think it's ever been used. It makes sense to remove it! |
dOrgJelli
dismissed stale reviews from nerfZael and Niraj-Kamdar
via
4d3db19
dOrgJelli
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.