update concurrent plugin interface uri#1496
Merged
Merged
Conversation
krisbitney
requested review from
dOrgJelli,
namesty,
nerfZael and
pileks
as code owners
cbrzn
approved these changes
Jan 30, 2023
Contributor
cbrzn
left a comment
cbrzn
left a comment
There was a problem hiding this comment.
cool! should we also update the wrappers that are in goerli to a text record in mainnet? following the same pattern as interfaces?
Contributor
Author
Yeah, for sure. I'll do it in another PR. |
dOrgJelli
approved these changes
Feb 1, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the concurrent plugin to use an ENS text record URI