Move WebSocket plugin to https://github.com/polywrap/WebSocket#1547
Merged
Conversation
krisbitney
requested review from
dOrgJelli,
namesty and
nerfZael
as code owners
Contributor
this was done on purpose because we don't use the ws plugin, so there wasn't a need to add this dependency |
Contributor
Author
Okay, cool. I assumed it was on purpose but I just wanted to check. |
Niraj-Kamdar
previously approved these changes
Feb 17, 2023
cbrzn
previously approved these changes
Feb 17, 2023
Contributor
cbrzn
left a comment
cbrzn
left a comment
There was a problem hiding this comment.
with this PR, the build:plugins command has been removed 😄
arigato @krisbitney for pushing this forward!!! really happy to finally see this 😋
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I moved the WebSocket plugin to its own repo at https://github.com/polywrap/WebSocket. I created an interface wrapper, based on the plugin's schema, and made the plugin implement the interface.
I've noticed the WebSocket plugin was never in the default client config. Was this intentional or an oversight? Should we add it?