Only install bison as a dependency for ruby < 3.3.0 (issue #509).

Author: postmodern

share/ruby-install/ruby/dependencies.sh

@@ -5,7 +5,6 @@ case "$package_manager" in
 		ruby_dependencies=(
 			xz-utils
 			build-essential
-			bison
 			zlib1g-dev
 			libyaml-dev
 			libssl-dev
@@ -19,7 +18,6 @@ case "$package_manager" in
 			xz
 			gcc
 			automake
-			bison
 			zlib-devel
 			libyaml-devel
 			openssl-devel
@@ -33,7 +31,6 @@ case "$package_manager" in
 			xz
 			gcc
 			make
-			bison
 			zlib
 			ncurses
 			openssl
@@ -60,7 +57,6 @@ case "$package_manager" in
 		ruby_dependencies=(
 			xz
 			automake
-			bison
 			readline
 			libyaml
 			libffi
@@ -87,6 +83,17 @@ case "$package_manager" in
 		;;
 esac
 
+#
+# Add bison as a build dependency for ruby < 3.3.0.
+#
+if [[ "$ruby_version" < "3.3.0" ]]; then
+	case "$package_manager" in
+		apt|dnf|yum|pacman|brew|port)
+			ruby_dependencies+=(bison)
+			;;
+	esac
+fi
+
 #
 # Add gdbm as a dependency for ruby < 3.1.0.
 #

test/functions-tests/load_dependencies_test.sh

@@ -6,7 +6,7 @@
 function setUp()
 {
 	ruby="ruby"
-	ruby_version="3.3.0"
+	ruby_version="3.4.0"
 	package_manager="dnf"
 }
 
@@ -15,7 +15,7 @@ function test_load_dependencies()
 	load_dependencies
 
 	assertEquals "did not correctly set \$ruby_dependencies from \$ruby/dependencies.sh for \$package_manager" \
-		     "xz gcc automake bison zlib-devel libyaml-devel openssl-devel readline-devel ncurses-devel libffi-devel" \
+		     "xz gcc automake zlib-devel libyaml-devel openssl-devel readline-devel ncurses-devel libffi-devel" \
 		     "${ruby_dependencies[*]}"
 }
 

test/ruby-tests/dependencies_tests.sh

@@ -6,7 +6,7 @@
 function setUp()
 {
 	ruby="ruby"
-	ruby_version="3.2.0"
+	ruby_version="3.4.0"
 }
 
 function test_when_package_manager_is_apt()
@@ -20,7 +20,7 @@ function test_when_package_manager_is_apt()
 	           "$openssl_version"
 
 	assertEquals "did not correctly set \$ruby_dependencies" \
-		     "xz-utils build-essential bison zlib1g-dev libyaml-dev libssl-dev libreadline-dev libncurses-dev libffi-dev" \
+		     "xz-utils build-essential zlib1g-dev libyaml-dev libssl-dev libreadline-dev libncurses-dev libffi-dev" \
 		     "${ruby_dependencies[*]}"
 
 	package_manager="$original_package_manager"
@@ -37,7 +37,7 @@ function test_when_package_manager_is_dnf()
 	           "$openssl_version"
 
 	assertEquals "did not correctly set \$ruby_dependencies" \
-		     "xz gcc automake bison zlib-devel libyaml-devel openssl-devel readline-devel ncurses-devel libffi-devel" \
+		     "xz gcc automake zlib-devel libyaml-devel openssl-devel readline-devel ncurses-devel libffi-devel" \
 		     "${ruby_dependencies[*]}"
 
 	package_manager="$original_package_manager"
@@ -54,7 +54,7 @@ function test_when_package_manager_is_yum()
 	           "$openssl_version"
 
 	assertEquals "did not correctly set \$ruby_dependencies" \
-		     "xz gcc automake bison zlib-devel libyaml-devel openssl-devel readline-devel ncurses-devel libffi-devel" \
+		     "xz gcc automake zlib-devel libyaml-devel openssl-devel readline-devel ncurses-devel libffi-devel" \
 		     "${ruby_dependencies[*]}"
 
 	package_manager="$original_package_manager"
@@ -71,7 +71,7 @@ function test_when_package_manager_is_pacman()
 	           "$openssl_version"
 
 	assertEquals "did not correctly set \$ruby_dependencies" \
-		     "xz gcc make bison zlib ncurses openssl readline libyaml libffi" \
+		     "xz gcc make zlib ncurses openssl readline libyaml libffi" \
 		     "${ruby_dependencies[*]}"
 
 	package_manager="$original_package_manager"
@@ -128,6 +128,90 @@ function test_when_package_manager_is_xbps()
 	package_manager="$original_package_manager"
 }
 
+function test_when_ruby_version_is_less_than_3_3_0_and_package_manager_is_apt()
+{
+	local original_package_manager="$package_manager"
+	package_manager="apt"
+	ruby_version="3.2.0"
+
+	source "$ruby_install_dir/$ruby/dependencies.sh"
+
+	assertTrue "did not add bison to \$ruby_dependencies" \
+	           '[[ " ${ruby_dependencies[*]} " == *" bison "* ]]'
+
+	package_manager="$original_package_manager"
+}
+
+function test_when_ruby_version_is_less_than_3_3_0_and_package_manager_is_dnf()
+{
+	local original_package_manager="$package_manager"
+	package_manager="dnf"
+	ruby_version="3.2.0"
+
+	source "$ruby_install_dir/$ruby/dependencies.sh"
+
+	assertTrue "did not add bison to \$ruby_dependencies" \
+	           '[[ " ${ruby_dependencies[*]} " == *" bison "* ]]'
+
+	package_manager="$original_package_manager"
+}
+
+function test_when_ruby_version_is_less_than_3_3_0_and_package_manager_is_yum()
+{
+	local original_package_manager="$package_manager"
+	package_manager="yum"
+	ruby_version="3.2.0"
+
+	source "$ruby_install_dir/$ruby/dependencies.sh"
+
+	assertTrue "did not add bison to \$ruby_dependencies" \
+	           '[[ " ${ruby_dependencies[*]} " == *" bison "* ]]'
+
+	package_manager="$original_package_manager"
+}
+
+function test_when_ruby_version_is_less_than_3_3_0_and_package_manager_is_pacman()
+{
+	local original_package_manager="$package_manager"
+	package_manager="pacman"
+	ruby_version="3.2.0"
+
+	source "$ruby_install_dir/$ruby/dependencies.sh"
+
+	assertTrue "did not add bison to \$ruby_dependencies" \
+	           '[[ " ${ruby_dependencies[*]} " == *" bison "* ]]'
+
+	package_manager="$original_package_manager"
+}
+
+function test_when_ruby_version_is_less_than_3_3_0_and_package_manager_is_brew()
+{
+	local original_package_manager="$package_manager"
+	package_manager="brew"
+	ruby_version="3.2.0"
+
+	source "$ruby_install_dir/$ruby/dependencies.sh"
+
+	assertTrue "did not add bison to \$ruby_dependencies" \
+	           '[[ " ${ruby_dependencies[*]} " == *" bison "* ]]'
+
+	package_manager="$original_package_manager"
+}
+
+function test_when_ruby_version_is_less_than_3_3_0_and_package_manager_is_port()
+{
+	local original_package_manager="$package_manager"
+	package_manager="port"
+	ruby_version="3.2.0"
+
+	source "$ruby_install_dir/$ruby/dependencies.sh"
+
+	assertTrue "did not add bison to \$ruby_dependencies" \
+	           '[[ " ${ruby_dependencies[*]} " == *" bison "* ]]'
+
+	package_manager="$original_package_manager"
+}
+
 function test_when_ruby_version_is_less_than_3_1_0_and_package_manager_is_apt()
 {
 	local original_package_manager="$package_manager"