Skip to content

Commit 1d52d8e

Browse files
committed
netty: suppress linter warning about Ignoring returned Futures
1 parent 2ce6ddf commit 1d52d8e

File tree

1 file changed

+7
-4
lines changed

1 file changed

+7
-4
lines changed

netty/src/main/java/io/grpc/netty/ProtocolNegotiators.java

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -184,6 +184,7 @@ private SslHandler sslHandler(ChannelPipeline pipeline) {
184184
return pipeline.get(SslHandler.class);
185185
}
186186

187+
@SuppressWarnings("FutureReturnValueIgnored")
187188
private void fail(ChannelHandlerContext ctx, Throwable exception) {
188189
logSslEngineDetails(Level.FINE, ctx, "TLS negotiation failed for new client.", exception);
189190
ctx.close();
@@ -525,6 +526,7 @@ public void channelInactive(ChannelHandlerContext ctx) throws Exception {
525526
* will fail immediately.
526527
*/
527528
@Override
529+
@SuppressWarnings("FutureReturnValueIgnored")
528530
public void write(ChannelHandlerContext ctx, Object msg, ChannelPromise promise)
529531
throws Exception {
530532
/**
@@ -582,6 +584,7 @@ public void close(ChannelHandlerContext ctx, ChannelPromise future) throws Excep
582584
/**
583585
* Propagate failures to all buffered writes.
584586
*/
587+
@SuppressWarnings("FutureReturnValueIgnored")
585588
protected final void fail(ChannelHandlerContext ctx, Throwable cause) {
586589
if (failCause == null) {
587590
failCause = cause;
@@ -595,13 +598,12 @@ protected final void fail(ChannelHandlerContext ctx, Throwable cause) {
595598
bufferedWrites = null;
596599
}
597600

598-
/**
599-
* In case something goes wrong ensure that the channel gets closed as the
600-
* NettyClientTransport relies on the channel's close future to get completed.
601-
*/
601+
// In case something goes wrong ensure that the channel gets closed as the
602+
// NettyClientTransport relies on the channel's close future to get completed.
602603
ctx.close();
603604
}
604605

606+
@SuppressWarnings("FutureReturnValueIgnored")
605607
protected final void writeBufferedAndRemove(ChannelHandlerContext ctx) {
606608
if (!ctx.channel().isActive() || writing) {
607609
return;
@@ -751,6 +753,7 @@ public AsciiString scheme() {
751753
}
752754

753755
@Override
756+
@SuppressWarnings("FutureReturnValueIgnored")
754757
public void channelActive(ChannelHandlerContext ctx) throws Exception {
755758
// Trigger the HTTP/1.1 plaintext upgrade protocol by issuing an HTTP request
756759
// which causes the upgrade headers to be added

0 commit comments

Comments
 (0)