Fix VarnodeBank.locRange(AddressSpace) not returning negative addresses

sad-dev · ghidracadabra · commit d96ae1a284bd · 2024-11-19T19:30:33.000Z
diff --git a/Ghidra/Framework/SoftwareModeling/src/main/java/ghidra/program/model/pcode/VarnodeBank.java b/Ghidra/Framework/SoftwareModeling/src/main/java/ghidra/program/model/pcode/VarnodeBank.java
@@ -210,7 +210,7 @@ public Iterator<VarnodeAST> locRange() {
 	}
 	
 	public Iterator<VarnodeAST> locRange(AddressSpace spaceid) {
-		VarnodeAST searchvn1 = new VarnodeAST(spaceid.getAddress(0),0,0);
+		VarnodeAST searchvn1 = new VarnodeAST(spaceid.getMinAddress(),0,0);
 		searchvn1.setInput(true);
 		VarnodeAST searchvn2 = new VarnodeAST(spaceid.getMaxAddress(), Integer.MAX_VALUE, 0);
 		return locTree.subSet(searchvn1, searchvn2).iterator();

Original file line number	Diff line number	Diff line change
`@@ -210,7 +210,7 @@ public Iterator<VarnodeAST> locRange() {`
`210`	`210`	`}`
`211`	`211`
`212`	`212`	`public Iterator<VarnodeAST> locRange(AddressSpace spaceid) {`
`213`		`- VarnodeAST searchvn1 = new VarnodeAST(spaceid.getAddress(0),0,0);`
	`213`	`+ VarnodeAST searchvn1 = new VarnodeAST(spaceid.getMinAddress(),0,0);`
`214`	`214`	`searchvn1.setInput(true);`
`215`	`215`	`VarnodeAST searchvn2 = new VarnodeAST(spaceid.getMaxAddress(), Integer.MAX_VALUE, 0);`
`216`	`216`	`return locTree.subSet(searchvn1, searchvn2).iterator();`