From 2e239bc77ab6215cb68325f91291bd72ae648ed7 Mon Sep 17 00:00:00 2001 From: Jon Rohan Date: Tue, 24 Sep 2024 22:01:09 +0000 Subject: [PATCH 1/2] Move Label to ga feature flag --- e2e/components/Label.test.ts | 52 +++++++++++++++--------------- packages/react/src/Label/Label.tsx | 2 +- 2 files changed, 27 insertions(+), 27 deletions(-) diff --git a/e2e/components/Label.test.ts b/e2e/components/Label.test.ts index 6fd977f9215..e54f64022d3 100644 --- a/e2e/components/Label.test.ts +++ b/e2e/components/Label.test.ts @@ -14,7 +14,7 @@ test.describe('Label', () => { globals: { colorScheme: theme, featureFlags: { - primer_react_css_modules_staff: enabled, + primer_react_css_modules_ga: enabled, }, }, }) @@ -29,7 +29,7 @@ test.describe('Label', () => { globals: { colorScheme: theme, featureFlags: { - primer_react_css_modules_staff: enabled, + primer_react_css_modules_ga: enabled, }, }, }) @@ -54,7 +54,7 @@ test.describe('Label', () => { globals: { colorScheme: theme, featureFlags: { - primer_react_css_modules_staff: enabled, + primer_react_css_modules_ga: enabled, }, }, }) @@ -69,7 +69,7 @@ test.describe('Label', () => { globals: { colorScheme: theme, featureFlags: { - primer_react_css_modules_staff: enabled, + primer_react_css_modules_ga: enabled, }, }, }) @@ -94,7 +94,7 @@ test.describe('Label', () => { globals: { colorScheme: theme, featureFlags: { - primer_react_css_modules_staff: enabled, + primer_react_css_modules_ga: enabled, }, }, }) @@ -109,7 +109,7 @@ test.describe('Label', () => { globals: { colorScheme: theme, featureFlags: { - primer_react_css_modules_staff: enabled, + primer_react_css_modules_ga: enabled, }, }, }) @@ -134,7 +134,7 @@ test.describe('Label', () => { globals: { colorScheme: theme, featureFlags: { - primer_react_css_modules_staff: enabled, + primer_react_css_modules_ga: enabled, }, }, }) @@ -149,7 +149,7 @@ test.describe('Label', () => { globals: { colorScheme: theme, featureFlags: { - primer_react_css_modules_staff: enabled, + primer_react_css_modules_ga: enabled, }, }, }) @@ -174,7 +174,7 @@ test.describe('Label', () => { globals: { colorScheme: theme, featureFlags: { - primer_react_css_modules_staff: enabled, + primer_react_css_modules_ga: enabled, }, }, }) @@ -189,7 +189,7 @@ test.describe('Label', () => { globals: { colorScheme: theme, featureFlags: { - primer_react_css_modules_staff: enabled, + primer_react_css_modules_ga: enabled, }, }, }) @@ -214,7 +214,7 @@ test.describe('Label', () => { globals: { colorScheme: theme, featureFlags: { - primer_react_css_modules_staff: enabled, + primer_react_css_modules_ga: enabled, }, }, }) @@ -229,7 +229,7 @@ test.describe('Label', () => { globals: { colorScheme: theme, featureFlags: { - primer_react_css_modules_staff: enabled, + primer_react_css_modules_ga: enabled, }, }, }) @@ -254,7 +254,7 @@ test.describe('Label', () => { globals: { colorScheme: theme, featureFlags: { - primer_react_css_modules_staff: enabled, + primer_react_css_modules_ga: enabled, }, }, }) @@ -269,7 +269,7 @@ test.describe('Label', () => { globals: { colorScheme: theme, featureFlags: { - primer_react_css_modules_staff: enabled, + primer_react_css_modules_ga: enabled, }, }, }) @@ -294,7 +294,7 @@ test.describe('Label', () => { globals: { colorScheme: theme, featureFlags: { - primer_react_css_modules_staff: enabled, + primer_react_css_modules_ga: enabled, }, }, }) @@ -309,7 +309,7 @@ test.describe('Label', () => { globals: { colorScheme: theme, featureFlags: { - primer_react_css_modules_staff: enabled, + primer_react_css_modules_ga: enabled, }, }, }) @@ -334,7 +334,7 @@ test.describe('Label', () => { globals: { colorScheme: theme, featureFlags: { - primer_react_css_modules_staff: enabled, + primer_react_css_modules_ga: enabled, }, }, }) @@ -349,7 +349,7 @@ test.describe('Label', () => { globals: { colorScheme: theme, featureFlags: { - primer_react_css_modules_staff: enabled, + primer_react_css_modules_ga: enabled, }, }, }) @@ -374,7 +374,7 @@ test.describe('Label', () => { globals: { colorScheme: theme, featureFlags: { - primer_react_css_modules_staff: enabled, + primer_react_css_modules_ga: enabled, }, }, }) @@ -389,7 +389,7 @@ test.describe('Label', () => { globals: { colorScheme: theme, featureFlags: { - primer_react_css_modules_staff: enabled, + primer_react_css_modules_ga: enabled, }, }, }) @@ -414,7 +414,7 @@ test.describe('Label', () => { globals: { colorScheme: theme, featureFlags: { - primer_react_css_modules_staff: enabled, + primer_react_css_modules_ga: enabled, }, }, }) @@ -429,7 +429,7 @@ test.describe('Label', () => { globals: { colorScheme: theme, featureFlags: { - primer_react_css_modules_staff: enabled, + primer_react_css_modules_ga: enabled, }, }, }) @@ -454,7 +454,7 @@ test.describe('Label', () => { globals: { colorScheme: theme, featureFlags: { - primer_react_css_modules_staff: enabled, + primer_react_css_modules_ga: enabled, }, }, }) @@ -469,7 +469,7 @@ test.describe('Label', () => { globals: { colorScheme: theme, featureFlags: { - primer_react_css_modules_staff: enabled, + primer_react_css_modules_ga: enabled, }, }, }) @@ -494,7 +494,7 @@ test.describe('Label', () => { globals: { colorScheme: theme, featureFlags: { - primer_react_css_modules_staff: enabled, + primer_react_css_modules_ga: enabled, }, }, }) @@ -509,7 +509,7 @@ test.describe('Label', () => { globals: { colorScheme: theme, featureFlags: { - primer_react_css_modules_staff: enabled, + primer_react_css_modules_ga: enabled, }, }, }) diff --git a/packages/react/src/Label/Label.tsx b/packages/react/src/Label/Label.tsx index 6fe7a1e0bf3..7c2f6db5960 100644 --- a/packages/react/src/Label/Label.tsx +++ b/packages/react/src/Label/Label.tsx @@ -100,7 +100,7 @@ const StyledLabel = styled.span` ` const Label = React.forwardRef(function Label({as, size = 'small', variant = 'default', className, ...rest}, ref) { - const enabled = useFeatureFlag('primer_react_css_modules_staff') + const enabled = useFeatureFlag('primer_react_css_modules_ga') if (enabled) { const Component = as || 'span' if (rest.sx) { From 81cfabda3c3c52bb0babcefb2f8d2f7a9ffd0810 Mon Sep 17 00:00:00 2001 From: Jon Rohan Date: Tue, 24 Sep 2024 15:02:04 -0700 Subject: [PATCH 2/2] Create silent-planes-grab.md --- .changeset/silent-planes-grab.md | 5 +++++ 1 file changed, 5 insertions(+) create mode 100644 .changeset/silent-planes-grab.md diff --git a/.changeset/silent-planes-grab.md b/.changeset/silent-planes-grab.md new file mode 100644 index 00000000000..24c4bf37622 --- /dev/null +++ b/.changeset/silent-planes-grab.md @@ -0,0 +1,5 @@ +--- +"@primer/react": patch +--- + +Move Label component feature flag from primer_react_css_modules_staff to primer_react_css_modules_ga