From 505fbdc318e0056ebc1c8dedf6ea72ba91a852e7 Mon Sep 17 00:00:00 2001 From: Jeremy Mickelson Date: Mon, 8 May 2017 10:41:13 -0600 Subject: [PATCH 1/2] Use the document instead of the body to determine the height of the page --- src/affix/affix.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/affix/affix.js b/src/affix/affix.js index 8f9cc6f22..db117d948 100644 --- a/src/affix/affix.js +++ b/src/affix/affix.js @@ -12,7 +12,7 @@ angular.module('mgcrea.ngStrap.affix', ['mgcrea.ngStrap.helpers.dimensions', 'mg this.$get = function ($window, debounce, dimensions) { - var bodyEl = angular.element($window.document.body); + var document = angular.element($window.document); var windowEl = angular.element($window); function AffixFactory (element, config) { @@ -116,7 +116,7 @@ angular.module('mgcrea.ngStrap.affix', ['mgcrea.ngStrap.helpers.dimensions', 'mg } if (options.inlineStyles) { element.css('position', (options.offsetParent) ? '' : 'relative'); - element.css('top', (options.offsetParent) ? '' : ((bodyEl[0].offsetHeight - offsetBottom - elementHeight - initialOffsetTop) + 'px')); + element.css('top', (options.offsetParent) ? '' : ((documentEl.height() - offsetBottom - elementHeight - initialOffsetTop) + 'px')); } } else { // affix === 'middle' unpin = null; From 7aa3ebc4c7dd0fff2e560a2d638850734a8bb2c2 Mon Sep 17 00:00:00 2001 From: Jeremy Mickelson Date: Mon, 8 May 2017 10:55:29 -0600 Subject: [PATCH 2/2] Fix var name --- src/affix/affix.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/affix/affix.js b/src/affix/affix.js index db117d948..9343d8a07 100644 --- a/src/affix/affix.js +++ b/src/affix/affix.js @@ -12,7 +12,7 @@ angular.module('mgcrea.ngStrap.affix', ['mgcrea.ngStrap.helpers.dimensions', 'mg this.$get = function ($window, debounce, dimensions) { - var document = angular.element($window.document); + var documentEl = angular.element($window.document); var windowEl = angular.element($window); function AffixFactory (element, config) {