From 2f1e71c8d7c4247a493fa79f2b5ff9d8e3169d27 Mon Sep 17 00:00:00 2001 From: piersh Date: Mon, 19 Feb 2018 18:37:46 -0800 Subject: [PATCH 1/3] move stroke lines towards camera --- src/webgl/shaders/line.vert | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/webgl/shaders/line.vert b/src/webgl/shaders/line.vert index 4fee2ab029..54d113f1a0 100644 --- a/src/webgl/shaders/line.vert +++ b/src/webgl/shaders/line.vert @@ -23,7 +23,7 @@ uniform mat4 uProjectionMatrix; uniform float uStrokeWeight; uniform vec4 uViewport; -vec3 scale = vec3(1.0); +vec3 scale = vec3(0.9995); attribute vec4 aPosition; attribute vec4 aDirection; From bba027dbf36362ca964442c595efd94c92089649 Mon Sep 17 00:00:00 2001 From: piersh Date: Mon, 19 Feb 2018 18:39:59 -0800 Subject: [PATCH 2/3] reduce default stroke width --- src/webgl/p5.RendererGL.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/webgl/p5.RendererGL.js b/src/webgl/p5.RendererGL.js index 3e672fa3d4..a0aa5391dd 100755 --- a/src/webgl/p5.RendererGL.js +++ b/src/webgl/p5.RendererGL.js @@ -123,7 +123,7 @@ p5.RendererGL = function(elt, pInst, isMainCanvas, attr) { this.fill(255, 255, 255, 255); //this.stroke(0, 0, 0, 255); this.pointSize = 5.0; //default point size - this.strokeWeight(2); + this.strokeWeight(1); this.stroke(0, 0, 0); // array of textures created in this gl context via this.getTexture(src) this.textures = []; From a71a3bc7e1f7f10c602b859f06d0fa9ca4c7203f Mon Sep 17 00:00:00 2001 From: Spongman Date: Thu, 22 Feb 2018 21:04:06 -0800 Subject: [PATCH 3/3] Update line.vert Add comment --- src/webgl/shaders/line.vert | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/webgl/shaders/line.vert b/src/webgl/shaders/line.vert index 54d113f1a0..cd6a48bba8 100644 --- a/src/webgl/shaders/line.vert +++ b/src/webgl/shaders/line.vert @@ -23,6 +23,10 @@ uniform mat4 uProjectionMatrix; uniform float uStrokeWeight; uniform vec4 uViewport; + +// using a scale <1 moves the lines towards the camera +// in order to prevent popping effects due to half of +// the line disappearing behind the geometry faces. vec3 scale = vec3(0.9995); attribute vec4 aPosition;