Skip to content

fix: resolve promote.ts TypeScript errors and add OAuth register command (fixes #403)#413

Merged
ralyodio merged 1 commit into
profullstack:masterfrom
Aiden181:fix/bug-testing-promote-and-oauth-register
May 23, 2026
Merged

fix: resolve promote.ts TypeScript errors and add OAuth register command (fixes #403)#413
ralyodio merged 1 commit into
profullstack:masterfrom
Aiden181:fix/bug-testing-promote-and-oauth-register

Conversation

@Aiden181
Copy link
Copy Markdown
Contributor

Summary

Bug fixes from ugig.net bug-testing gig + feature implementation for issue #403.

Bug Fixes

1. TypeScript Type Error in promote.ts

  • loadInstalledPackage() returns Promise<T | undefined>, but variables declared as SocialPlatform<unknown> | null = null. In strict TypeScript, undefined is not assignable to null.
  • Fix: Changed let adapter: SocialPlatform<unknown> | null = nulllet adapter: SocialPlatform<unknown> | undefined

2. Duplicate makeCliSetupContext in adapter-cmd.ts

  • Removed standalone local copy of makeCliSetupContext(), imported from shared ../setup-context.js

Feature: Issue #403 — OAuth App Registration Command

  • New sh1pt promote social register command
  • Lists 13 supported platforms with step-by-step OAuth registration guides
  • Displays redirect URIs and scopes, stores CLIENT_ID/SECRET in vault
  • Platforms: Facebook/Meta, X (Twitter), LinkedIn, Instagram, TikTok, Reddit, Google/YouTube, GitHub, Discord, Pinterest, Spotify, Snapchat, Twitch, Microsoft Azure AD

Verification

  • All 2544 tests pass
  • TypeScript typecheck passes clean

…and (fixes profullstack#403)

- Fix adapter-cmd.ts: remove duplicate makeCliSetupContext, import from shared setup-context.js
- Fix promote.ts: change SocialPlatform null initializers to undefined for strict TypeScript
- Feature: add 'sh1pt promote social register' command for OAuth app registration
- Covers 13 platforms with step-by-step guides, redirect URIs, scopes, and vault storage
@ralyodio ralyodio merged commit a1fbb0c into profullstack:master May 23, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants