Skip to content

Commit 5c10a3d

Browse files
committed
Remove redundant constructor validation from RelativeHumidityMeasurementCluster
1 parent 0d3a9ee commit 5c10a3d

File tree

1 file changed

+0
-19
lines changed

1 file changed

+0
-19
lines changed

src/app/clusters/relative-humidity-measurement-server/RelativeHumidityMeasurementCluster.cpp

Lines changed: 0 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -29,32 +29,13 @@ using namespace RelativeHumidityMeasurement::Attributes;
2929
constexpr uint16_t kMinMeasuredValueMax = 9999;
3030
// Global ceiling for any measured humidity value (applies to MeasuredValue and MaxMeasuredValue)
3131
constexpr uint16_t kMeasuredValueMax = 10000;
32-
// Tolerance max is 2048
33-
constexpr uint16_t kMaxTolerance = 2048;
3432

3533
RelativeHumidityMeasurementCluster::RelativeHumidityMeasurementCluster(EndpointId endpointId,
3634
const OptionalAttributeSet & optionalAttributeSet,
3735
const StartupConfiguration & config) :
3836
DefaultServerCluster({ endpointId, RelativeHumidityMeasurement::Id }),
3937
mOptionalAttributeSet(optionalAttributeSet)
4038
{
41-
if (!config.minMeasuredValue.IsNull())
42-
{
43-
VerifyOrDie(config.minMeasuredValue.Value() <= kMinMeasuredValueMax);
44-
45-
if (!config.maxMeasuredValue.IsNull())
46-
{
47-
VerifyOrDie(config.maxMeasuredValue.Value() >= config.minMeasuredValue.Value() + 1);
48-
}
49-
}
50-
51-
if (!config.maxMeasuredValue.IsNull())
52-
{
53-
VerifyOrDie(config.maxMeasuredValue.Value() <= kMeasuredValueMax);
54-
}
55-
56-
VerifyOrDie(!mOptionalAttributeSet.IsSet(Tolerance::Id) || config.tolerance <= kMaxTolerance);
57-
5839
mMinMeasuredValue = config.minMeasuredValue;
5940
mMaxMeasuredValue = config.maxMeasuredValue;
6041
mTolerance = config.tolerance;

0 commit comments

Comments
 (0)