Skip to content

Commit f14e427

Browse files
Drop check for ancient dbus versions
This check warned against using a very old dbus version that caused breakage. However, the check used the `distutils` package for version comparison, but that package is deprecated and will be removed in an upcoming python version. Since there does not seem to be a direct alternative for version comparisons in the core Python libraries and this check is about a 4-year old dbus version anyway, just remove the check rather than adding an extra dependency just for this.
1 parent bcbfaee commit f14e427

File tree

1 file changed

+0
-11
lines changed

1 file changed

+0
-11
lines changed

src/hamster/client.py

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,6 @@
2525
import sys
2626

2727
from calendar import timegm
28-
from distutils.version import LooseVersion
2928
from gi.repository import GObject as gobject
3029
from textwrap import dedent
3130

@@ -42,16 +41,6 @@
4241
from hamster.lib import datetime as dt
4342

4443

45-
# bug fixed in dbus-python 1.2.14 (released on 2019-11-25)
46-
assert not (
47-
sys.version_info >= (3, 8)
48-
and LooseVersion(dbus.__version__) < LooseVersion("1.2.14")
49-
), """python3.8 changed str(<dbus integers>).
50-
That broke hamster (https://github.com/projecthamster/hamster/issues/477).
51-
Please upgrade to dbus-python >= 1.2.14.
52-
"""
53-
54-
5544
class Storage(gobject.GObject):
5645
"""Hamster client class, communicating to hamster storage daemon via d-bus.
5746
Subscribe to the `tags-changed`, `facts-changed` and `activities-changed`

0 commit comments

Comments
 (0)