Skip to content

Commit 8982ab8

Browse files
committed
Fixup onLog for null vm for non-stream (Root) context.
Signed-off-by: John Plevyak <jplevyak@gmail.com>
1 parent a21abb5 commit 8982ab8

File tree

2 files changed

+4
-1
lines changed

2 files changed

+4
-1
lines changed

include/proxy-wasm/context_interface.h

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -179,6 +179,9 @@ struct RootInterface : public RootGrpcInterface {
179179
*/
180180
virtual bool onDone() = 0;
181181

182+
// Call when the for logging not associated with a stream lifecycle (e.g. logging only plugin).
183+
virtual void onLog() = 0;
184+
182185
/**
183186
* Call when no further stream calls will occur. This will cause the corresponding Context in the
184187
* VM to be deleted.

src/null/null_plugin.cc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -472,7 +472,7 @@ void NullPlugin::onLog(uint64_t context_id) {
472472
registry_->proxy_on_log_(context_id);
473473
return;
474474
}
475-
getContext(context_id)->onLog();
475+
getContextBase(context_id)->onLog();
476476
}
477477

478478
uint64_t NullPlugin::onDone(uint64_t context_id) {

0 commit comments

Comments
 (0)