Skip to content

Commit b28b757

Browse files
committed
address feedback
1 parent 2c843f7 commit b28b757

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

pkg/codegen/customresourcegenerator.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -175,7 +175,7 @@ func sanitizeReferenceName(fieldName string) string {
175175
return "Arguments"
176176
}
177177

178-
//We need to strip out any hyphens and underscores in the reference.
178+
// We need to strip out any hyphens and underscores in the reference.
179179
fieldName = cgstrings.Unhyphenate(fieldName)
180180
fieldName = cgstrings.ModifyStringAroundDelimeter(fieldName, "_", cgstrings.UppercaseFirst)
181181

@@ -209,7 +209,7 @@ func crdToOpenAPI(crd *extensionv1.CustomResourceDefinition) ([]*spec.Swagger, e
209209
return openAPIManifests, nil
210210
}
211211

212-
// fillDefaultNames sets the default names for the CRD if they are not specified.
212+
// setCRDDefaults sets the default names for the CRD if they are not specified.
213213
// This allows the OpenAPI builder to generate the swagger specs correctly with
214214
// the correct defaults.
215215
func setCRDDefaults(crd *extensionv1.CustomResourceDefinition) {

tests/crds_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -99,7 +99,7 @@ func TestCRDsFromUrl(t *testing.T) {
9999
})
100100
}
101101

102-
// TODO: Also run compilation tests for java and python.
102+
// TODO(#145): Also run compilation tests for java and python.
103103
compileValidationFn := map[string]func(t *testing.T, path string){
104104
"nodejs": validateNodeCompiles,
105105
"go": validateGolangCompiles,

0 commit comments

Comments
 (0)