From a7af80d84ce161ef507c4167f7dfd4b3e44ac340 Mon Sep 17 00:00:00 2001 From: Marshall Bowers Date: Sat, 6 Nov 2021 22:24:46 -0400 Subject: [PATCH 1/2] Add an `isSpace` test for a CJK character --- test/Test/Data/CodePoint/Unicode.purs | 2 ++ 1 file changed, 2 insertions(+) diff --git a/test/Test/Data/CodePoint/Unicode.purs b/test/Test/Data/CodePoint/Unicode.purs index 6631618..a265f8a 100644 --- a/test/Test/Data/CodePoint/Unicode.purs +++ b/test/Test/Data/CodePoint/Unicode.purs @@ -238,6 +238,8 @@ isSpaceTests = describe "isSpace" do isSpace (codePointFromChar '\t') `shouldEqual` true it "'a' is not Space" $ isSpace (codePointFromChar 'a') `shouldEqual` false + it "'日' is not Space" $ + isSpace (codePointFromChar '日') `shouldEqual` false isUpperTests :: forall m. MonadReader Int m => MonadEffect m => m Unit isUpperTests = describe "isUpper" do From 5cef82ae4172c95a904528222e1953ca7bc0f9aa Mon Sep 17 00:00:00 2001 From: Marshall Bowers Date: Sat, 6 Nov 2021 22:28:26 -0400 Subject: [PATCH 2/2] Update changelog --- CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 614fc77..da62c30 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -12,6 +12,7 @@ Bugfixes: Other improvements: - Run `isLowerTests` in tests (#35 by @JordanMartinez) +- Added test for CJK characters for `isSpace` (#36 by @maxdeviant) ## [v5.0.0](https://github.com/purescript-contrib/purescript-unicode/releases/tag/v5.0.0) - 2021-02-26