From d98815c582fd26f78e0f2376ede12b860c053a02 Mon Sep 17 00:00:00 2001 From: Jack Kelly Date: Fri, 25 Feb 2022 16:01:19 +0000 Subject: [PATCH 1/5] Fix tiny typo in docs --- docs/sphinx/source/user_guide/pvsystem.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/sphinx/source/user_guide/pvsystem.rst b/docs/sphinx/source/user_guide/pvsystem.rst index 3ca09ff443..ae9344483c 100644 --- a/docs/sphinx/source/user_guide/pvsystem.rst +++ b/docs/sphinx/source/user_guide/pvsystem.rst @@ -117,7 +117,7 @@ PVSystem and Arrays The PVSystem class can represent a PV system with a single array of modules, or with multiple arrays. For a PV system with a single array, the parameters that describe the array can be provided directly to the PVSystem instand. -For example, the parameters that describe the array's modules are can be +For example, the parameters that describe the array's modules can be passed to `PVSystem.module_parameters`: .. ipython:: python From 8fababd01ae34fae3aefc2a02f625c006a91efdc Mon Sep 17 00:00:00 2001 From: Jack Kelly Date: Fri, 25 Feb 2022 16:24:30 +0000 Subject: [PATCH 2/5] Deleting an extraneous "for" in docs --- docs/sphinx/source/user_guide/modelchain.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/sphinx/source/user_guide/modelchain.rst b/docs/sphinx/source/user_guide/modelchain.rst index 8c7c87486f..63a1d0618a 100644 --- a/docs/sphinx/source/user_guide/modelchain.rst +++ b/docs/sphinx/source/user_guide/modelchain.rst @@ -15,7 +15,7 @@ A :py:class:`~.modelchain.ModelChain` has three components: * a :py:class:`~.pvsystem.PVSystem` object, representing a collection of modules and inverters * a :py:class:`~.location.Location` object, representing a location on the planet -* values for attributes that specify the model to be used for for each step in the PV modeling +* values for attributes that specify the model to be used for each step in the PV modeling process. Modeling with a :py:class:`~.ModelChain` typically involves 3 steps: From 0b536b8e5672413c36f6c7560c1014e77d4497fe Mon Sep 17 00:00:00 2001 From: Jack Kelly Date: Fri, 25 Feb 2022 16:59:28 +0000 Subject: [PATCH 3/5] Fix tiny typo in wind pvsyst_cell docs --- pvlib/temperature.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pvlib/temperature.py b/pvlib/temperature.py index eb960701bd..6a4ed1fd6e 100644 --- a/pvlib/temperature.py +++ b/pvlib/temperature.py @@ -305,7 +305,7 @@ def pvsyst_cell(poa_global, temp_air, wind_speed=1.0, u_c=29.0, u_v=0.0, wind_speed : numeric, default 1.0 Wind speed in m/s measured at the same height for which the wind loss - factor was determined. The default value 1.0 m/2 is the wind + factor was determined. The default value 1.0 m/s is the wind speed at module height used to determine NOCT. [m/s] u_c : float, default 29.0 From 38c823f5ca0ac6f5c946009b3925bb99c92760bf Mon Sep 17 00:00:00 2001 From: Jack Kelly Date: Mon, 28 Feb 2022 09:04:20 +0000 Subject: [PATCH 4/5] Adding myself to the list of contributors --- docs/sphinx/source/whatsnew/v0.9.1.rst | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/docs/sphinx/source/whatsnew/v0.9.1.rst b/docs/sphinx/source/whatsnew/v0.9.1.rst index 55cac900b2..f55f4fa83b 100644 --- a/docs/sphinx/source/whatsnew/v0.9.1.rst +++ b/docs/sphinx/source/whatsnew/v0.9.1.rst @@ -53,7 +53,7 @@ Documentation ~~~~~~~~~~~~~ * Fix documentation return error in :py:meth:`pvlib.forecast.ForecastModel.cloud_cover_to_transmittance_linear` (:issue:`1367`, :pull:`1370`) - +* Fix some typos. Requirements ~~~~~~~~~~~~ @@ -69,3 +69,4 @@ Contributors * Kevin Anderson (:ghuser:`kanderso-nrel`) * Adam R. Jensen (:ghuser:`AdamRJensen`) * Johann Loux (:ghuser:`JoLo90`) +* Jack Kelly (:ghuser:`JackKelly`) From 6168b06dae32c6f6f9cb0ebb2a1720aea6bd6232 Mon Sep 17 00:00:00 2001 From: Jack Kelly Date: Mon, 28 Feb 2022 09:05:39 +0000 Subject: [PATCH 5/5] Add link to the pull request --- docs/sphinx/source/whatsnew/v0.9.1.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/sphinx/source/whatsnew/v0.9.1.rst b/docs/sphinx/source/whatsnew/v0.9.1.rst index f55f4fa83b..ddd747d2d0 100644 --- a/docs/sphinx/source/whatsnew/v0.9.1.rst +++ b/docs/sphinx/source/whatsnew/v0.9.1.rst @@ -53,7 +53,7 @@ Documentation ~~~~~~~~~~~~~ * Fix documentation return error in :py:meth:`pvlib.forecast.ForecastModel.cloud_cover_to_transmittance_linear` (:issue:`1367`, :pull:`1370`) -* Fix some typos. +* Fix some typos (:pull:`1414`) Requirements ~~~~~~~~~~~~