Non blocking fish prompt#457
Closed
furudean wants to merge 1 commit into
Closed
Conversation
Member
|
There are side effects: at prompt time, changes made by activating an environment won't yet be in effect. This would affect things like interactive completion. |
Author
|
Fair enough |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I propose this as a less intrusive alternative to #451. This can be dropped in as a stop gap to ease some frustration for fish users. I think the philosophy in #451 is a better approach if we can figure out all the difficult bits.
This PR will make pyenv run before the command executes and won't block the prompt from showing, which feels a lot better to use.
See also #338