✨ feat(plugin): add U flag to unset env variables#188
Merged
Conversation
gaborbernat
changed the title
Setting a variable to empty string isn't the same as removing it from the environment. The new U: flag (INI) and unset key (TOML) allow removing variables from os.environ, following the existing D:/R: flag pattern. Closes pytest-dev#89
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently pytest-env can only set environment variables — there's no way to remove one from
os.environ. Setting a variable to an empty string (VAR=) is not the same as unsetting it: code checkingif key in os.environstill sees it. This matters for libraries and frameworks that branch on variable presence rather than value.The new
U:flag follows the existingD:andR:prefix convention for INI config, and adds anunsetkey for the TOML inline-table format. In INI:U:DATABASE_URL. In TOML:DATABASE_URL = {unset = true}. When processed, the plugin callsos.environ.pop(key, None)instead of setting a value. ✨ Unsetting is safe to apply to variables that don't exist, and entries are processed in order so a subsequent set after an unset works as expected.Fixes #89