Skip to content
This repository was archived by the owner on May 4, 2020. It is now read-only.

Tests from xlwt3#42

Merged
cjw296 merged 5 commits into
python-excel:masterfrom
takluyver:manfred-tests
Apr 21, 2014
Merged

Tests from xlwt3#42
cjw296 merged 5 commits into
python-excel:masterfrom
takluyver:manfred-tests

Conversation

@takluyver
Copy link
Copy Markdown
Contributor

Adds tests from Manfred Moitzi's xlwt3 port, and gets them passing with xlwt on Python 2.

Don't merge this until Manfred has agreed to relicense the tests, as they currently say GPL3 at the top of each file. He agreed to do this for the xlrd tests, and I've emailed him about it, so I'm optimistic that he'll OK that soon.

@takluyver
Copy link
Copy Markdown
Contributor Author

OK, Manfred agreed to relicense the tests - see this xlwt3 commit. So this should be ready to go.

I've also added a Travis config file, so once this is merged, a repository admin can log into Travis and flip the switch to start automated tests.

@takluyver takluyver mentioned this pull request Apr 8, 2014
@cjw296
Copy link
Copy Markdown
Member

cjw296 commented Apr 13, 2014

Why are there changes to CompoundDoc.py in this pull request?

@takluyver
Copy link
Copy Markdown
Contributor Author

Three private methods have their names changed to start with a single underscore instead of a double underscore, because the tests call them. I tried using double underscores in the tests, but ran into issues with the name mangling that Python does for leading-double-underscore methods. Since they're private methods anyway, tweaking their names seemed like the easiest thing to do.

cjw296 added a commit that referenced this pull request Apr 21, 2014
@cjw296 cjw296 merged commit a063d90 into python-excel:master Apr 21, 2014
@takluyver
Copy link
Copy Markdown
Contributor Author

@cjw296 If you log in to https://travis-ci.org/ , you should be able to click one button to enable automatic tests on new commits.

@cjw296
Copy link
Copy Markdown
Member

cjw296 commented Apr 21, 2014

Already done...

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants