Python 3 support by takluyver · Pull Request #46 · python-excel/xlwt

takluyver · 2014-04-26T20:41:06Z

Following discussion on PR #32, this adds Python 3 support without any external dependencies. Python 2.6 and above and Python 3.3 and above should work; older versions will not.

The tests are passing on Python 2 and 3; I haven't tried the examples.

It's not clear why they're different, but I've checked them manually and they appear exactly the same.

jreback · 2014-04-26T20:53:39Z

👍

takluyver · 2014-06-09T17:25:18Z

@cjw296 : I just wanted to make sure this hasn't fallen off the radar. The tests appear to be passing.

ghost · 2014-06-17T15:26:52Z

👍

cjw296 · 2014-10-22T23:00:47Z

Does losing the L have an impact on Py2?

No, ints are automatically upgraded to longs if left-shifting takes them past maxint.

sontek · 2015-01-20T22:37:37Z

To help with this I added a PR to this PR:

takluyver#1

That adds tox and pytest support and fixes bugs in a test that wasn't being ran by nose.

sontek · 2015-01-20T22:47:13Z

What is left to get this merged in? I'd love to see it :)

Add tox and pytest support to catch additional bugs

sontek · 2015-01-20T23:44:16Z

With takluyver#2 I've added the badges for pypi, coveralls, and travis. We should enable coveralls on this repo to get the badge working properly.

sontek · 2015-01-20T23:49:16Z

@cjw296 Beers on me at PyCon if you merge this :) 🍻 🍸

collinanderson · 2015-01-21T02:56:33Z

+1

cjw296 · 2015-01-21T07:41:23Z

I'm coming to 3 days of sprints at PyCon with the express intent of merging this.
@sontek, hopefully you and @takluyver can be there to help?

sontek · 2015-01-21T07:49:07Z

@cjw296 we were hoping to get a release prior to pycon. We just ported all our stuff to py3 and want to have it fully in prod running stable releases before pycon.

Could we consider merging this to a develop/feature branch and release a prerelease version people can test out?

Are there specific things in this PR you feel aren't ready that we could help with?

takluyver · 2015-01-21T17:29:54Z

I will be at Pycon, but I'd be happy to get this merged before then. I can think of more interesting things to be working on during the few days of sprints with Pythonistas from around the world.

tjanez · 2015-03-08T16:12:34Z

Hi!

Any progress on this?

alexandre · 2015-03-19T19:12:43Z

up

collinanderson · 2015-03-19T19:33:16Z

(btw if it helps, xlwt-future has py3 support, though beware it doesn't play will with newrelic)

Python 3 support

takluyver · 2015-04-13T16:41:10Z

Woo! 🎉 ✨ 🍰

nicklasb · 2015-04-13T17:57:44Z

I know what they fix, the blatant lack of back doors.
Woo!! . :-)

cjw296 · 2015-04-13T20:48:30Z

@nicklasb - huh?

nicklasb · 2015-04-13T20:50:55Z

Just kidding.
Just wrt big commits that do more then they say and that I understand your apprehension. :-)

takluyver added 22 commits April 26, 2014 11:19

Run python-modernize print fixer

b173abc

Run python modernize with 'except' and 'raise' fixes

4dddd72

Remove unnecessary L suffixes on int literals

1a11262

Run modernize with 'ne' fixer

36c8d85

Remove another L suffix

a84120c

Run modernize with import fixer - explicit relative imports

d0f4801

Define text types and unicode function in compat

66f3cc1

Define xrange in compat

b7f7ba3

file -> open

d816e87

Add int_types in compat

19be3b7

Remove assignments to True and False

a13f6e9

Remove __init__ from __slots__

04fc8aa

Start fixing up antlr

327ab26

Clean up various scope and naming issues in antlr.py

b0f21a7

Some import fixes

7b388e0

Refactor file writing tests

7b20fa5

Ignore test output directory

8f82dd1

Another xrange use

2bf01e6

Add iteritems and itervalues functions for dictionaries

8390407

Use bytes where appropriate

5e51a13

Update test files

26d0422

It's not clear why they're different, but I've checked them manually and they appear exactly the same.

Add Travis testing on Python 3.3

f14fb7e

takluyver mentioned this pull request Apr 26, 2014

Py3.3 support for xlwt #32

Closed

takluyver added 4 commits April 27, 2014 10:04

Fix bytes comparison

7b714a5

Fix some more bytes strings

7c6b62e

Fix Python 3 compatibility in some examples

40b11a3

Don't try to write solitary surrogates in unicode2 example

d64e171

cjw296 reviewed Oct 22, 2014
View reviewed changes

takluyver and others added 5 commits October 22, 2014 16:53

Remove unused (& previously broken) get_rec_id method

a1f5c84

Move Row and Column to regular imports in Worksheet

ca77dbe

Use ascii encoding for owner name

773667b

Revert some unrelated changes to antlr.py

eaf12cf

Add tox and pytest support to catch additional bugs

7bc354b

Merge pull request #1 from sontek/add_pytest_tox

efc7c36

Add tox and pytest support to catch additional bugs

cjw296 added a commit that referenced this pull request Apr 13, 2015

Merge pull request #46 from takluyver/py3

5e479b8

Python 3 support

cjw296 merged commit 5e479b8 into python-excel:master Apr 13, 2015

Conversation

takluyver commented Apr 26, 2014

Uh oh!

jreback commented Apr 26, 2014

Uh oh!

takluyver commented Jun 9, 2014

Uh oh!

ghost commented Jun 17, 2014

Uh oh!

cjw296 Oct 22, 2014

Choose a reason for hiding this comment

Uh oh!

takluyver Oct 22, 2014

Choose a reason for hiding this comment

Uh oh!

cjw296 Nov 8, 2014

Choose a reason for hiding this comment

Uh oh!

sontek commented Jan 20, 2015

Uh oh!

sontek commented Jan 20, 2015

Uh oh!

sontek commented Jan 20, 2015

Uh oh!

sontek commented Jan 20, 2015

Uh oh!

collinanderson commented Jan 21, 2015

Uh oh!

cjw296 commented Jan 21, 2015

Uh oh!

sontek commented Jan 21, 2015

Uh oh!

takluyver commented Jan 21, 2015

Uh oh!

tjanez commented Mar 8, 2015

Uh oh!

alexandre commented Mar 19, 2015

Uh oh!

collinanderson commented Mar 19, 2015

Uh oh!

takluyver commented Apr 13, 2015

Uh oh!

nicklasb commented Apr 13, 2015

Uh oh!

cjw296 commented Apr 13, 2015

Uh oh!

nicklasb commented Apr 13, 2015

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

12 participants