Add service name label by default #84
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexppg
changed the title
avara1986
reviewed
Jan 31, 2020
| if metrics_config: | ||
| metrics = PrometheusMetricsFactory() | ||
| service_name = self.component_name.lower().replace("-", "_").replace(" ", "_") | ||
| metrics = PrometheusMetricsFactory(service_name_label=service_name) |
Member
There was a problem hiding this comment.
Fail the tests with service_name_label param 😉
Member
Author
There was a problem hiding this comment.
My bad, I thought I executed them locally. I forgot to update the lock, it seems.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It adds a label to all jaeger's generated metrics that can be used to identify every microservice.
See jaegertracing/jaeger-client-python#269.
I messed up the previous PR, it's the same as this. #72