fix: support periods in repository names

[yosofbadr]

Summary

Fixes #1328

• Repository names containing periods (e.g. my.repo) were broken because add_property, get_property, and remove_property in config sources blindly split on ., treating periods in the name as key separators
• Added a split_key() helper that accepts either a dotted string or a pre-split list[str], and updated the ConfigSource interface accordingly
• Updated all call sites that embed repository names (http-basic, pypi-token, repositories, certificates) to pass pre-split key lists, preserving names with periods as single key segments
• The certificates regex was also updated from [^.]+ to .+ to allow periods in repository names for certificate config

Test plan

• All 89 existing config tests pass
• All 33 existing password manager tests pass
• Added 7 new tests covering list-key operations in both DictConfigSource and FileConfigSource:
  • test_dict_config_source_add_property_with_list_keys
  • test_dict_config_source_get_property_with_list_keys
  • test_dict_config_source_remove_property_with_list_keys
  • test_dict_config_source_add_property_with_periods_in_repo_name
  • test_file_config_source_add_property_with_list_keys
  • test_file_config_source_get_property_with_list_keys
  • test_file_config_source_remove_property_with_list_keys
• Manual test: poetry config repositories.my.repo https://example.com/simple/ should create [repositories."my.repo"] instead of [repositories.my.repo]
• Manual test: poetry config http-basic.my.repo user pass should store credentials under "my.repo" key

[sourcery-ai]

Hey - I've found 2 issues, and left some high level feedback:

• The new repos?(?:itories)? regex in config now only special-cases the url subkey; previously repositories.<name>.<anything> would work, whereas now other subkeys (e.g. repositories.foo.verify) will no longer be parsed as a separate sub-property—if this is not intentional, consider making the second capture group generic rather than hard-coding url.
• In the config command, when a specific sub-property is requested (e.g. .url) but the repository value is not a dict, the code silently returns the whole value; it may be clearer to raise an error in this case to avoid confusing output when the structure is unexpected.
• The split_key helper and the updated interfaces currently require list[str]; if you want to keep callsites flexible and easier to compose, consider accepting a more generic Sequence[str] or Iterable[str] and only materializing a list internally.

Prompt for AI Agents

Please address the comments from this code review:

## Overall Comments
- The new `repos?(?:itories)?` regex in `config` now only special-cases the `url` subkey; previously `repositories.<name>.<anything>` would work, whereas now other subkeys (e.g. `repositories.foo.verify`) will no longer be parsed as a separate sub-property—if this is not intentional, consider making the second capture group generic rather than hard-coding `url`.
- In the `config` command, when a specific sub-property is requested (e.g. `.url`) but the repository value is not a dict, the code silently returns the whole value; it may be clearer to raise an error in this case to avoid confusing output when the structure is unexpected.
- The `split_key` helper and the updated interfaces currently require `list[str]`; if you want to keep callsites flexible and easier to compose, consider accepting a more generic `Sequence[str]` or `Iterable[str]` and only materializing a list internally.

## Individual Comments

### Comment 1
<location path="src/poetry/console/commands/config.py" line_range="195-197" />
<code_context>
+                        )

-                    value = repo
+                    if m.group(2):
+                        # User asked for a specific sub-property (e.g. .url)
+                        value = repo.get(m.group(2), repo) if isinstance(repo, dict) else repo
+                    else:
+                        value = repo
</code_context>
<issue_to_address>
**issue (bug_risk):** Returning the full repo config when the requested sub-key is missing is surprising and may hide configuration issues.

When `repositories.<name>.url` is requested and `url` is missing, this will return the entire `repo` dict instead of failing or returning `None`. That both hides misconfigurations and violates the expectation that a more specific path returns a more specific value. Consider returning `None` or raising when `m.group(2)` is present but the key is absent, e.g.:

```python
if isinstance(repo, dict):
    value = repo.get(m.group(2))
else:
    value = repo
```

This preserves the current behavior for `repositories.<name>` while making `repositories.<name>.url` predictable.
</issue_to_address>

### Comment 2
<location path="tests/console/commands/test_config.py" line_range="231" />
<code_context>
@pytest.mark.parametrize(
</code_context>
<issue_to_address>
**suggestion (testing):** Consider adding tests around certificates with repository names containing periods

This PR also relaxes the certificates regex (`certificates.(.+).(cert|client-cert)`) and switches those paths to list-based keys. Please add tests that cover `poetry config certificates.my.repo.cert` / `client-cert` (including the unset case) to ensure the CLI behavior matches the new config semantics and that repo names with periods are preserved correctly in certificate configuration.
</issue_to_address>

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[radoering]

@sourcery-ai review

[sourcery-ai]

Hey - I've found 1 issue

Prompt for AI Agents

Please address the comments from this code review:

## Individual Comments

### Comment 1
<location path="src/poetry/config/config_source.py" line_range="23-32" />
<code_context>
 UNSET = object()


+def split_key(key: str | Sequence[str]) -> list[str]:
+    """Split a config key into its component parts.
+
+    If the key is already a list, return it as-is.
+    If the key is a string, split on periods.
+
+    Use a list when the key contains segments with periods
+    (e.g. repository names like "my.repo").
+    """
+    if isinstance(key, str):
+        return key.split(".")
+    return list(key)
</code_context>
<issue_to_address>
**nitpick:** The `split_key` docstring implies it returns a list unchanged, but it actually accepts any sequence and always copies.

The docstring says "If the key is already a list, return it as-is.", but the function accepts `Sequence[str]` and always does `list(key)` for non-strings, so it both supports more than lists and always copies. If copying is intentional, please update the docstring to say it accepts any `Sequence[str]` and always returns a new list of segments.
</issue_to_address>

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}