From 4d1d54c2a5edb1b81acdb5fc675c11c24446bf01 Mon Sep 17 00:00:00 2001
From: A5rocks <git@helvetica.moe>
Date: Thu, 26 Dec 2024 08:30:39 +0900
Subject: [PATCH 1/2] Stop failing CI upon codecov error 503

---
 .github/workflows/ci.yml | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
index a6f31c1064..cdedc8f5d2 100644
--- a/.github/workflows/ci.yml
+++ b/.github/workflows/ci.yml
@@ -223,8 +223,6 @@ jobs:
           # multiple flags is marked as an error in codecov UI, but is actually fine
           # https://github.com/codecov/feedback/issues/567
           flags: Windows,${{ matrix.python }}
-          # this option cannot be set in .codecov.yml
-          fail_ci_if_error: true
 
   Ubuntu:
     name: 'Ubuntu (${{ matrix.python }}${{ matrix.extra_name }})'
@@ -288,7 +286,6 @@ jobs:
           directory: empty
           name: Ubuntu (${{ matrix.python }}${{ matrix.extra_name }})
           flags: Ubuntu,${{ matrix.python }}
-          fail_ci_if_error: true
 
   macOS:
     name: 'macOS (${{ matrix.python }})'
@@ -330,7 +327,6 @@ jobs:
           directory: empty
           name: macOS (${{ matrix.python }})
           flags: macOS,${{ matrix.python }}
-          fail_ci_if_error: true
 
   # run CI on a musl linux
   Alpine:
@@ -366,7 +362,6 @@ jobs:
           directory: empty
           name: Alpine
           flags: Alpine,${{ steps.get-version.outputs.version }}
-          fail_ci_if_error: true
 
   Cython:
     name: "Cython"
@@ -426,7 +421,6 @@ jobs:
         with:
           name: Cython
           flags: Cython,${{ steps.get-version.outputs.version }}
-          fail_ci_if_error: true
 
   # https://github.com/marketplace/actions/alls-green#why
   check:  # This job does nothing and is only used for the branch protection

From 8e2bfa9e864755019a0f58f9b0090dbaa09ea4bd Mon Sep 17 00:00:00 2001
From: EXPLOSION <git@helvetica.moe>
Date: Sun, 29 Dec 2024 13:01:27 +0900
Subject: [PATCH 2/2] Explicitly state that disabling CI failures is temporary

---
 .github/workflows/ci.yml | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
index cdedc8f5d2..47a2c1d7d4 100644
--- a/.github/workflows/ci.yml
+++ b/.github/workflows/ci.yml
@@ -223,6 +223,7 @@ jobs:
           # multiple flags is marked as an error in codecov UI, but is actually fine
           # https://github.com/codecov/feedback/issues/567
           flags: Windows,${{ matrix.python }}
+          fail_ci_if_error: false  # change to true when using codecov action v5
 
   Ubuntu:
     name: 'Ubuntu (${{ matrix.python }}${{ matrix.extra_name }})'
@@ -286,6 +287,7 @@ jobs:
           directory: empty
           name: Ubuntu (${{ matrix.python }}${{ matrix.extra_name }})
           flags: Ubuntu,${{ matrix.python }}
+          fail_ci_if_error: false
 
   macOS:
     name: 'macOS (${{ matrix.python }})'
@@ -327,6 +329,7 @@ jobs:
           directory: empty
           name: macOS (${{ matrix.python }})
           flags: macOS,${{ matrix.python }}
+          fail_ci_if_error: false
 
   # run CI on a musl linux
   Alpine:
@@ -362,6 +365,7 @@ jobs:
           directory: empty
           name: Alpine
           flags: Alpine,${{ steps.get-version.outputs.version }}
+          fail_ci_if_error: false
 
   Cython:
     name: "Cython"
@@ -421,6 +425,7 @@ jobs:
         with:
           name: Cython
           flags: Cython,${{ steps.get-version.outputs.version }}
+          fail_ci_if_error: false
 
   # https://github.com/marketplace/actions/alls-green#why
   check:  # This job does nothing and is only used for the branch protection