Skip to content

Commit 2b594a9

Browse files
Update encoding_test
1 parent 713d1a3 commit 2b594a9

1 file changed

Lines changed: 10 additions & 22 deletions

File tree

Lib/test/test_modulefinder.py

Lines changed: 10 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -273,7 +273,7 @@ def create_package(source):
273273

274274

275275
class ModuleFinderTest(unittest.TestCase):
276-
def _do_test(self, info, report=False, debug=0, replace_paths=[], encoding=False):
276+
def _do_test(self, info, report=False, debug=0, replace_paths=[]):
277277
import_this, modules, missing, maybe_missing, source = info
278278
create_package(source)
279279
try:
@@ -301,15 +301,6 @@ def _do_test(self, info, report=False, debug=0, replace_paths=[], encoding=False
301301
self.assertEqual(bad, missing)
302302
self.assertEqual(maybe, maybe_missing)
303303

304-
# check for modules encoding
305-
if encoding:
306-
for module in mf.modules.items():
307-
module_name, module_object = module
308-
file = open(module_object.__file__, 'rb')
309-
encoding = tokenize.detect_encoding(file.readline)[0]
310-
self.assertEqual(encoding, 'iso-8859-1')
311-
file.close()
312-
313304
finally:
314305
shutil.rmtree(TEST_DIR)
315306

@@ -364,18 +355,15 @@ def test_replace_paths(self):
364355
self.assertIn(expected, output)
365356

366357
def test_encoding(self):
367-
encoding_test = [
368-
"a",
369-
["a", "b"],
370-
[], [],
371-
"""\
372-
a.py
373-
# coding=latin-1
374-
import b
375-
b.py
376-
# coding=latin-1
377-
"""]
378-
self._do_test(encoding_test, encoding=True)
358+
finder = modulefinder.ModuleFinder()
359+
with open('f.py', 'w', encoding='cp1252') as f:
360+
f.write('import b\nx = "€"\b')
361+
finder.run_script(f.name)
362+
for name, mod in finder.modules.items():
363+
file = open(mod.__file__, 'rb')
364+
encoding = tokenize.detect_encoding(file.readline)[0]
365+
self.assertEqual(encoding, 'cp1252')
366+
file.close()
379367

380368
def test_extended_opargs(self):
381369
extended_opargs_test = [

0 commit comments

Comments
 (0)