[3.8] bpo-38168: Fix a possbile refleak in setint() of mmapmodule.c (GH-16136) (GH-16174)

miss-islington · web-flow · commit 322309efe658 · 2019-09-15T23:26:57.000-07:00
(cherry picked from commit 56a4514) Co-authored-by: Hai Shi <shihai1992@gmail.com> https://bugs.python.org/issue38168 Automerge-Triggered-By: @zhangyangyu
diff --git a/Modules/mmapmodule.c b/Modules/mmapmodule.c
@@ -1468,7 +1468,8 @@ static void
 setint(PyObject *d, const char *name, long value)
 {
     PyObject *o = PyLong_FromLong(value);
-    if (o && PyDict_SetItemString(d, name, o) == 0) {
+    if (o) {
+        PyDict_SetItemString(d, name, o);
         Py_DECREF(o);
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -1468,7 +1468,8 @@ static void`
`1468`	`1468`	`setint(PyObject d, const char name, long value)`
`1469`	`1469`	`{`
`1470`	`1470`	`PyObject *o = PyLong_FromLong(value);`
`1471`		`- if (o && PyDict_SetItemString(d, name, o) == 0) {`
	`1471`	`+ if (o) {`
	`1472`	`+ PyDict_SetItemString(d, name, o);`
`1472`	`1473`	`Py_DECREF(o);`
`1473`	`1474`	`}`
`1474`	`1475`	`}`