gh-145559: Make PyUnstable_DumpTraceback void return

hoodmane · hoodmane · commit 5b08fae0b993 · 2026-07-19T15:39:36.000+02:00
In gh-148145, we changed this to return a const char* but it is always NULL. I don't think this makes sense, so this puts it back.
diff --git a/Python/traceback.c b/Python/traceback.c
@@ -1167,11 +1167,10 @@ dump_traceback(int fd, PyThreadState *tstate, int write_header)
 
    The caller is responsible to call PyErr_CheckSignals() to call Python signal
    handlers if signals were received. */
-const char*
+void
 PyUnstable_DumpTraceback(int fd, PyThreadState *tstate)
 {
     dump_traceback(fd, tstate, 1);
-    return NULL;
 }
 
 #if defined(HAVE_PTHREAD_GETNAME_NP) || defined(HAVE_PTHREAD_GET_NAME_NP)

Original file line number	Diff line number	Diff line change
`@@ -1167,11 +1167,10 @@ dump_traceback(int fd, PyThreadState *tstate, int write_header)`
`1167`	`1167`
`1168`	`1168`	`The caller is responsible to call PyErr_CheckSignals() to call Python signal`
`1169`	`1169`	`handlers if signals were received. */`
`1170`		`-const char*`
	`1170`	`+void`
`1171`	`1171`	`PyUnstable_DumpTraceback(int fd, PyThreadState *tstate)`
`1172`	`1172`	`{`
`1173`	`1173`	`dump_traceback(fd, tstate, 1);`
`1174`		`- return NULL;`
`1175`	`1174`	`}`
`1176`	`1175`
`1177`	`1176`	`#if defined(HAVE_PTHREAD_GETNAME_NP) \|\| defined(HAVE_PTHREAD_GET_NAME_NP)`