Skip to content

Commit e291f3b

Browse files
Trim the NEWS entry to the user-visible statement
Review feedback from StanFromIreland: no implementation details (the BIT_MASK macro name is meaningless to users), no description of how it was fixed (the diff carries that), and no note about the suppressions file.
1 parent 721f6ce commit e291f3b

1 file changed

Lines changed: 2 additions & 7 deletions

File tree

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,2 @@
1-
Fix undefined behaviour in the :mod:`ctypes` bit field accessors. The
2-
``BIT_MASK``, ``GET_BITFIELD`` and ``SET`` macros in
3-
``Modules/_ctypes/cfield.c`` shifted negative values left and shifted ones
4-
into the sign bit of a signed type. The bit manipulation is now done in
5-
``uint64_t`` and converted back to the field's own type, which removes the
6-
two ``Modules/_ctypes/cfield.c`` entries from
7-
``Tools/ubsan/suppressions.txt``.
1+
Fix undefined behaviour when reading and writing :mod:`ctypes` bit fields of
2+
a signed type.

0 commit comments

Comments
 (0)