From 330a63534fa433723b2c377847b9385e71db42e1 Mon Sep 17 00:00:00 2001 From: Cheryl Sabella Date: Fri, 4 Jan 2019 19:14:43 -0500 Subject: [PATCH 1/2] bpo-35660: IDLE: Remove * import from window.py * sys was being imported through the *, so also added an import sys. --- Lib/idlelib/window.py | 3 ++- Misc/NEWS.d/next/IDLE/2019-01-04-19-14-29.bpo-35660.hMxI7N.rst | 1 + 2 files changed, 3 insertions(+), 1 deletion(-) create mode 100644 Misc/NEWS.d/next/IDLE/2019-01-04-19-14-29.bpo-35660.hMxI7N.rst diff --git a/Lib/idlelib/window.py b/Lib/idlelib/window.py index b2488b28cabe7ef..460d5b67948dde2 100644 --- a/Lib/idlelib/window.py +++ b/Lib/idlelib/window.py @@ -1,4 +1,5 @@ -from tkinter import * +from tkinter import Toplevel, TclError +import sys class WindowList: diff --git a/Misc/NEWS.d/next/IDLE/2019-01-04-19-14-29.bpo-35660.hMxI7N.rst b/Misc/NEWS.d/next/IDLE/2019-01-04-19-14-29.bpo-35660.hMxI7N.rst new file mode 100644 index 000000000000000..7a00ec4e4c29658 --- /dev/null +++ b/Misc/NEWS.d/next/IDLE/2019-01-04-19-14-29.bpo-35660.hMxI7N.rst @@ -0,0 +1 @@ +Remove use of `from tkinter import *` from window.py. From 4ed3d1443fce861166fe3582bbd4cda3dcc60f77 Mon Sep 17 00:00:00 2001 From: Terry Jan Reedy Date: Sat, 5 Jan 2019 14:24:21 -0500 Subject: [PATCH 2/2] Update 2019-01-04-19-14-29.bpo-35660.hMxI7N.rst Anyone who wants details can check the issue, where I added the point about the sys import bug. --- Misc/NEWS.d/next/IDLE/2019-01-04-19-14-29.bpo-35660.hMxI7N.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Misc/NEWS.d/next/IDLE/2019-01-04-19-14-29.bpo-35660.hMxI7N.rst b/Misc/NEWS.d/next/IDLE/2019-01-04-19-14-29.bpo-35660.hMxI7N.rst index 7a00ec4e4c29658..1ad83fe29e144f6 100644 --- a/Misc/NEWS.d/next/IDLE/2019-01-04-19-14-29.bpo-35660.hMxI7N.rst +++ b/Misc/NEWS.d/next/IDLE/2019-01-04-19-14-29.bpo-35660.hMxI7N.rst @@ -1 +1 @@ -Remove use of `from tkinter import *` from window.py. +Fix imports in idlelib.window.