bpo-41662: Fix bugs in binding parameters in sqlite3#21998
Merged
serhiy-storchaka merged 3 commits intoSep 17, 2020
Conversation
* When the parameters argument is a list, correctly handle the case of changing it during iteration. * When the parameters argument is a custom sequence, no longer override an exception raised in ``__len__()``.
serhiy-storchaka
added
type-bug
berkerpeksag
left a comment
berkerpeksag
left a comment
Member
There was a problem hiding this comment.
Not sure how common is the second case, but I think it wouldn't hurt to have a test for the first case. Other than that, it looks good to me!
| @@ -0,0 +1 @@ | |||
| Fixed two rare bugs in binding parameters in the :mod:`sqlite3` module. | |||
Member
There was a problem hiding this comment.
Unfortunately, this doesn't give readers any meaningful information so if you think it's not easy to explain what we are fixing here, I'd say it's OK to not add a NEWS entry.
Member
Author
There was a problem hiding this comment.
Does it look better now? I added two separate entries for two bugs.
Contributor
|
Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8, 3.9. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Sep 17, 2020
* When the parameters argument is a list, correctly handle the case of changing it during iteration. * When the parameters argument is a custom sequence, no longer override an exception raised in ``__len__()``. (cherry picked from commit 0b419b7) Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
|
GH-22289 is a backport of this pull request to the 3.9 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Sep 17, 2020
* When the parameters argument is a list, correctly handle the case of changing it during iteration. * When the parameters argument is a custom sequence, no longer override an exception raised in ``__len__()``. (cherry picked from commit 0b419b7) Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
|
GH-22290 is a backport of this pull request to the 3.8 branch. |
miss-islington
added a commit
that referenced
this pull request
Sep 17, 2020
* When the parameters argument is a list, correctly handle the case of changing it during iteration. * When the parameters argument is a custom sequence, no longer override an exception raised in ``__len__()``. (cherry picked from commit 0b419b7) Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
xzy3
pushed a commit
to xzy3/cpython
that referenced
this pull request
Oct 18, 2020
* When the parameters argument is a list, correctly handle the case of changing it during iteration. * When the parameters argument is a custom sequence, no longer override an exception raised in ``__len__()``.
methane
pushed a commit
that referenced
this pull request
Oct 26, 2020
* When the parameters argument is a list, correctly handle the case of changing it during iteration. * When the parameters argument is a custom sequence, no longer override an exception raised in ``__len__()``. (cherry picked from commit 0b419b7) Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
of changing it during iteration.
override an exception raised in
__len__().https://bugs.python.org/issue41662