v3: revamp: address review comments

Signed-off-by: Sugu Sougoumarane <ssougou@gmail.com>

Author: sougou

go/vt/vtgate/planbuilder/planbuilder.go

@@ -0,0 +1,35 @@
+/*
+Copyright 2018 The Vitess Authors.
+
+Licensed under the Apache License, Version 2.0 (the "License");
+you may not use this file except in compliance with the License.
+You may obtain a copy of the License at
+
+    http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing, software
+distributed under the License is distributed on an "AS IS" BASIS,
+WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+See the License for the specific language governing permissions and
+limitations under the License.
+*/
+
+package planbuilder
+
+// planBuilder is the top level type for building plans.
+// It contains the current builder tree, the symtab and
+// the jointab. It can create transient planBuilders due
+// to the recursive nature of SQL.
+type planBuilder struct {
+	vschema ContextVSchema
+	jt      *jointab
+	bldr    builder
+	st      *symtab
+}
+
+func newPlanBuilder(vschema ContextVSchema, jt *jointab) *planBuilder {
+	return &planBuilder{
+		vschema: vschema,
+		jt:      jt,
+	}
+}

go/vt/vtgate/planbuilder/select.go

@@ -24,24 +24,6 @@ import (
 	"vitess.io/vitess/go/vt/vtgate/engine"
 )
 
-// planBuilder is the top level type for building plans.
-// It contains the current builder tree, the symtab and
-// the jointab. It can create transient planBuilders due
-// to the recursive nature of SQL.
-type planBuilder struct {
-	vschema ContextVSchema
-	jt      *jointab
-	bldr    builder
-	st      *symtab
-}
-
-func newPlanBuilder(vschema ContextVSchema, jt *jointab) *planBuilder {
-	return &planBuilder{
-		vschema: vschema,
-		jt:      jt,
-	}
-}
-
 // buildSelectPlan is the new function to build a Select plan.
 func buildSelectPlan(sel *sqlparser.Select, vschema ContextVSchema) (primitive engine.Primitive, err error) {
 	pb := newPlanBuilder(vschema, newJointab(sqlparser.GetBindvars(sel)))