Fix the type signature of collision check methods. (#2578)

* Fix argument annotation for collides_with_list since the type of the sprites in the result depends on the type of sprites in the given `sprite_list`.

* Fix argument annotation for collides_with_sprite

* Closes #2576

Author: sjrd

arcade/sprite/base.py

@@ -801,7 +801,7 @@ def collides_with_point(self, point: Point2) -> bool:
         x, y = point
         return is_point_in_polygon(x, y, self.hit_box.get_adjusted_points())
 
-    def collides_with_sprite(self: SpriteType, other: SpriteType) -> bool:
+    def collides_with_sprite(self, other: BasicSprite) -> bool:
         """Will check if a sprite is overlapping (colliding) another Sprite.
 
         Args:
@@ -813,7 +813,7 @@ def collides_with_sprite(self: SpriteType, other: SpriteType) -> bool:
 
         return check_for_collision(self, other)
 
-    def collides_with_list(self: SpriteType, sprite_list: "SpriteList") -> list[SpriteType]:
+    def collides_with_list(self, sprite_list: SpriteList[SpriteType]) -> list[SpriteType]:
         """Check if current sprite is overlapping with any other sprite in a list
 
         Args:

arcade/sprite_list/collision.py

@@ -187,8 +187,8 @@ def _get_nearby_sprites(
 
 
 def check_for_collision_with_list(
-    sprite: SpriteType,
-    sprite_list: SpriteList,
+    sprite: BasicSprite,
+    sprite_list: SpriteList[SpriteType],
     method: int = 0,
 ) -> List[SpriteType]:
     """