From 42f971c0f73cc9fb80ee946e3c86ffede810fef2 Mon Sep 17 00:00:00 2001 From: Sam Gondelman Date: Thu, 6 Mar 2025 07:12:45 -0800 Subject: [PATCH] fix mman header issues Summary: fix from https://github.com/pytorch/executorch/pull/8989 Reviewed By: SS-JIA Differential Revision: D70680840 --- extension/data_loader/targets.bzl | 15 +++++++++++---- 1 file changed, 11 insertions(+), 4 deletions(-) diff --git a/extension/data_loader/targets.bzl b/extension/data_loader/targets.bzl index c23e4536520..50e779b4bd8 100644 --- a/extension/data_loader/targets.bzl +++ b/extension/data_loader/targets.bzl @@ -71,11 +71,18 @@ def define_common_targets(): name = "mmap_data_loader", srcs = [ "mmap_data_loader.cpp" - ] + (["mman_windows.cpp"] if host_info().os.is_windows else []), - headers = [ + ] + select({ + "DEFAULT": [], + "ovr_config//os:windows": ["mman_windows.cpp"], + }), + headers = select({ + "DEFAULT": [], + "ovr_config//os:windows": ["mman_windows.h"], + }), + exported_headers = [ "mman.h", - ] + (["mman_windows.h"] if host_info().os.is_windows else []), - exported_headers = ["mmap_data_loader.h"], + "mmap_data_loader.h" + ], visibility = [ "//executorch/test/...", "//executorch/extension/pybindings/...",