From 767fea70be84374553245b0a35966f680a44aac7 Mon Sep 17 00:00:00 2001 From: Erik Gaasedelen Date: Fri, 26 Oct 2018 13:28:50 -0700 Subject: [PATCH 1/2] move area calculation out of loop No need to calculate area 10 times when it doesn't change. --- torchvision/transforms/transforms.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/torchvision/transforms/transforms.py b/torchvision/transforms/transforms.py index 85dc68314f2..c11000cbf68 100644 --- a/torchvision/transforms/transforms.py +++ b/torchvision/transforms/transforms.py @@ -553,8 +553,9 @@ def get_params(img, scale, ratio): tuple: params (i, j, h, w) to be passed to ``crop`` for a random sized crop. """ + area = img.size[0] * img.size[1] + for attempt in range(10): - area = img.size[0] * img.size[1] target_area = random.uniform(*scale) * area aspect_ratio = random.uniform(*ratio) From 9c932be2a3c71fe4f5ebe1db2f930e0329f3f05b Mon Sep 17 00:00:00 2001 From: Erik Gaasedelen Date: Fri, 26 Oct 2018 13:32:47 -0700 Subject: [PATCH 2/2] lint --- torchvision/transforms/transforms.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/torchvision/transforms/transforms.py b/torchvision/transforms/transforms.py index c11000cbf68..f0a11432bbc 100644 --- a/torchvision/transforms/transforms.py +++ b/torchvision/transforms/transforms.py @@ -554,7 +554,7 @@ def get_params(img, scale, ratio): sized crop. """ area = img.size[0] * img.size[1] - + for attempt in range(10): target_area = random.uniform(*scale) * area aspect_ratio = random.uniform(*ratio)