From 93c414a1443c8ae7a32611210f6c8855032c6415 Mon Sep 17 00:00:00 2001 From: mhucka Date: Thu, 29 May 2025 23:19:15 +0000 Subject: [PATCH 1/3] Remove obsolete constructs from GetPybind11.cmake These constructs cause failures with newer versions of cmake. --- pybind_interface/GetPybind11.cmake | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/pybind_interface/GetPybind11.cmake b/pybind_interface/GetPybind11.cmake index 3f1e01afc..a9b4f527d 100644 --- a/pybind_interface/GetPybind11.cmake +++ b/pybind_interface/GetPybind11.cmake @@ -24,6 +24,5 @@ if (pybind11_FOUND) endif() if((NOT pybind11_FOUND) AND (NOT pybind11_POPULATED)) # check first on system path, then attempt git fetch - FetchContent_Populate(pybind11) - add_subdirectory(${pybind11_SOURCE_DIR} ${pybind11_BINARY_DIR}) + FetchContent_MakeAvailable(pybind11) endif() From c3f947a0404d55751f1b9a675cca63cbded00b48 Mon Sep 17 00:00:00 2001 From: mhucka Date: Thu, 29 May 2025 23:20:37 +0000 Subject: [PATCH 2/3] Add missing project declaration The lack of a `project(qsim)` declaration may not have been a problem with old versions of cmake, but in newer versions, its absence causes build failures. --- CMakeLists.txt | 2 ++ 1 file changed, 2 insertions(+) diff --git a/CMakeLists.txt b/CMakeLists.txt index 87057fca5..703e13081 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -1,3 +1,5 @@ +project(qsim) + set(CMAKE_CXX_STANDARD 11) cmake_minimum_required(VERSION 3.31) From c7f2b67308e6f08369e261b2db655275f90b7b8d Mon Sep 17 00:00:00 2001 From: mhucka Date: Mon, 9 Jun 2025 22:58:44 +0000 Subject: [PATCH 3/3] Add cmake file rules to .editorconfig --- .editorconfig | 3 +++ 1 file changed, 3 insertions(+) diff --git a/.editorconfig b/.editorconfig index b0898f1d5..7e25e15fc 100644 --- a/.editorconfig +++ b/.editorconfig @@ -38,6 +38,9 @@ max_line_length = 80 [{BUILD,*.BUILD,*.bzl,*.bazel,.bazelrc}] indent_size = 4 +[{CMakeLists.txt,*.cmake}] +indent_size = 4 + [{*.cc,*.h}] indent_size = 2