Update Dockerfiles and docker-compose.yml files#742
Merged
Conversation
Recent versions of Docker compose complain that this is an obsolete field and should be removed.
These are already installed in the `qsim` Docker image.
This matches what we get on GitHub runners.
This needs to install requirements.txt.
The main change is to install CMake 3.31.7 rather than to use the version installed by `apt install cmake`, because the latter version is too old (3.28). Some additional changes were needed to make things work on local Linux, Mac, and GitHub runners.
Subsequent Docker-based tests using the qsim Docker image can fail because they may lack some of the Python dependencies. Separately, best practices (at least according to `hadolint`) seem to be to use apt-get instead of apt, and to use `--no-install-recommends`.
The path to the venv bin directory was incorrect. Also, the sequence of events eneded to be adjusted slightly.
That was a mistake. Let's ignore hadolint's recommendation on this one.
With the qsim Docker container having more things preinsalled, this Dockerfile can be simplified further.
sergeisakov
approved these changes
Jun 13, 2025
dstrain115
approved these changes
Jun 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates the various Docker-related files to remove obsolete constructs, use Ubuntu 24.04 as the base OS instead of Debian, and overall, make things work on recent platforms.