Skip to content

Move most cibuildwheel options to pyproject.toml#748

Merged
mhucka merged 6 commits into
masterfrom
mh-add-pyproject
Jun 13, 2025
Merged

Move most cibuildwheel options to pyproject.toml#748
mhucka merged 6 commits into
masterfrom
mh-add-pyproject

Conversation

@mhucka
Copy link
Copy Markdown
Collaborator

@mhucka mhucka commented May 30, 2025

This adds a pyproject.toml file to the top level of the repository. The initial contents are settings for cibuildwheel and pytest. The cibuildwheel settings came from the GitHub Actions workflow for building wheels. Putting the settings here means the settings are available in more situations, such as when running cibuildwheel manually for testing, or if we create more scripts or workflows that run cibuildwheel. Since command-line options and environment variables override cibuildwheel values in pyproject.toml, these additions should not affect existing scripts and workflows.

The purpose of doing this now is to prepare for revised GitHub Actions workflows coming in another PR. These changes here need to be in place before the workflow changes.

Note: CI checks are failing, but not due to this file; it's because the CI workflows and other changes need to be made.

The initial contents are settings for cibuildwheel and pytest. The
cibuildwheel settings came from the GitHub Actions workflow for
building wheels. Putting the settings here means the settings are
available in more situations, such as when running cibuildwheel
manually for testing, or if we create more scripts or workflows that
run cibuildwheel.
@mhucka mhucka self-assigned this May 30, 2025
@mhucka mhucka requested review from dstrain115 and pavoljuhas May 30, 2025 18:11
@mhucka mhucka changed the title Start a pyproject.toml file Move most cibuildwheel options to pyproject.toml May 31, 2025
@mhucka mhucka marked this pull request as draft May 31, 2025 20:01
@mhucka mhucka marked this pull request as ready for review June 10, 2025 03:27
mhucka added 5 commits June 9, 2025 20:27
Otherwise, brew complains in a way that looks like errors in the GHA
run logs.
Attempting to run pytest with multithreaded parallel processes fails
on the GitHub Windows runners.
@mhucka mhucka removed their assignment Jun 12, 2025
@mhucka mhucka requested a review from sergeisakov June 13, 2025 15:56
@mhucka mhucka merged commit d5023d6 into master Jun 13, 2025
14 of 19 checks passed
@mhucka mhucka deleted the mh-add-pyproject branch June 13, 2025 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants