Slightly reduce tolerance on 2 expection value tests#755
Merged
Conversation
When running the Python test cases with NumPy 2, there are 2 cases that fail unless we loosen the numerical comparison tolerance by 1 order of magnitude. (Specifically, a tolerance of 1e-6 succeeds with NumPy 1, but fails in NumPy 2 unless I loosen the tolerance to 1e-5.) We should investigate the root cause (c.f. issue #754). For now, it seems reasonably safe to adjust these two tolerances.
mhucka
requested review from
dstrain115,
pavoljuhas and
sergeisakov
and removed request for
sergeisakov
dstrain115
approved these changes
Jun 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When running the Python test cases with NumPy 2, there are 2 cases that fail unless we loosen the numerical comparison tolerance by 1 order of magnitude. (Specifically, a tolerance of 1e-6 succeeds with NumPy 1, but fails in NumPy 2 unless I loosen the tolerance to 1e-5.)
We should investigate the root cause (c.f. issue #754). For now, it seems reasonably safe to adjust these two tolerances.